util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]

[Martin Liska]

For qemu-3.0.0 I see with GCC 9 compiler a new warning:

$ make -j1 -C roms pxerom VERBOSE=1 V=1
make: Entering directory '/home/abuild/rpmbuild/BUILD/qemu-3.0.0/roms'
make -C ipxe/src CONFIG=qemu \
 PACKAGING_TIMESTAMP=1534273834 \
 CROSS_COMPILE= \
 bin/8086100e.rom bin/808610d3.rom bin/80861209.rom bin/10500940.rom bin/10222000.rom bin/10ec8139.rom bin/1af41000.rom bin/15ad07b0.rom
make[1]: Entering directory '/home/abuild/rpmbuild/BUILD/qemu-3.0.0/roms/ipxe/src'
gcc -Wall -W -Wformat-nonliteral -O2 -g -Werror util/zbin.c -llzma -o util/zbin
util/zbin.c: In function 'process_zinfo_add':
util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
  390 | ( ( addend < 0 ) ? "-" : "" ), abs ( addend ), size,
      | ^~~
util/zbin.c:398:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
  398 | ( ( addend < 0 ) ? "-" : "" ), abs ( addend ), size,
      | ^~~
util/zbin.c:419:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
  419 | ( ( addend < 0 ) ? "-" : "" ), abs ( addend ),
      | ^~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile.housekeeping:1368: util/zbin] Error 1

[Peter Maydell (pmaydell)]

This bug would be better reported to the upstream for the ipxe rom -- we just ship the source code because we ship the binary.

[Martin Liska (mliska)]

Thank you, I contacted IPXE folks.

[Martin Liska (mliska)]

Should be fixed here:
http://git.ipxe.org/ipxe.git/commitdiff/956f6a722

Btw. how do you pull changes from ipxe into qemu repo?

[Peter Maydell (pmaydell)]

On Mon, 21 Jan 2019 at 12:47, Martin Liska <email address hidden> wrote:
>
> Should be fixed here:
> http://git.ipxe.org/ipxe.git/commitdiff/956f6a722
>
> Btw. how do you pull changes from ipxe into qemu repo?

The next step is a QEMU patch which updates our git submodule
to point at a version of IPXE with the fix and also has the
pre-built binaries corresponding to that new version.

Gerd, it looks like you did the last IPXE update -- could
we do another one with this fix in it?

thanks
-- PMM

[Gerd Hoffmann (kraxel-redhat)]

On Mon, Jan 21, 2019 at 12:57:16PM +0000, Peter Maydell wrote:
> On Mon, 21 Jan 2019 at 12:47, Martin Liska <email address hidden> wrote:
> >
> > Should be fixed here:
> > http://git.ipxe.org/ipxe.git/commitdiff/956f6a722
> >
> > Btw. how do you pull changes from ipxe into qemu repo?
>
> The next step is a QEMU patch which updates our git submodule
> to point at a version of IPXE with the fix and also has the
> pre-built binaries corresponding to that new version.
>
> Gerd, it looks like you did the last IPXE update -- could
> we do another one with this fix in it?

Yes, makes sense to do that, last ipxe rebase was more than a year ago.

cheers,
  Gerd

[Peter Maydell (pmaydell)]

In QEMU commit fd813c72392a712022d5d75a9 we upgraded our ipxe, so this bug should now be fixed in git master and in the upcoming 4.0 release.