Pcbnew: net names not shown unless very zoomed in or footprint selected

[John Beard]

On latest master, net names are not shown on the traces or pads unless very zoomed in or the footprint/trace is selected.

-----

Application: pcbnew
Version: (6.0.0-rc1-dev-1108-g8be3471ba), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.4) libssh2/1.8.0 nghttp2/1.34.0
Platform: Linux 4.18.16-arch1-1-ARCH x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.1 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Wayne Stambaugh (stambaughw)]

Something definitely changed from the 5.0 branch.

[Nick Østergaard (nickoe)]

I see this as well, I also notice that if you selected a footprint or just a pad of it the net will display at "normal" zoom levels.

[Nick Østergaard (nickoe)]

Ok, I just git bisected this bug, in the hope it is easier to narrow down where to fix this regression. I found the following.

64da77538f7a47545011dcb35d21b0be7bdbc82d is the first bad commit
commit 64da77538f7a47545011dcb35d21b0be7bdbc82d
Author: Maciej Suminski
Date: Mon Oct 22 00:16:15 2018 +0200

    Fix bitmap scale in printouts

    Display GALs had an incorrect world unit value set. Now the world unit
    value says how many internal units are in an inch, in accord with the comments
    in the GAL header. Bitmap drawing code relied on the information about DPI,
    so scaling worked differently for display and print GALs.

:040000 040000 9fe6a62b7749b3d0bd0b6580800c4997b9d36301 0e6b12132bb9edab14aa38921c163549a2b8ba59 M common
:040000 040000 66ce419b421ffbcad1a98f959e5d1af2605f3ff3 2bb80b2f73b7262e2430d2bebbf3dd8dfc0f37da M include
:040000 040000 69aa759dd8843cd0e37a5049506dc12d25c4aba6 c5f6ecc9e7bd7de11916a0a6a95ee03ca4a8586b M pcbnew

[Maciej Suminski (orsonmmz)]

Thanks Nick, I will have a look.

[Jeff Young (jeyjey)]

Didn't JP already fix this? I remember a commit go by that looked pretty similar, anyway....

[Maciej Suminski (orsonmmz)]

Unfortunately no, but ETA for the fix is 20 minutes.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 8d73cfef2a457d206e0ff6099a1d335ff89ede37
https://git.launchpad.net/kicad/patch/?id=8d73cfef2a457d206e0ff6099a1d335ff89ede37