Treat warning as errors on Windows
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Juniper Openstack | Status tracked in Trunk | |||||
Trunk |
In Progress
|
Undecided
|
Michał Cłapiński | |||
OpenContrail |
In Progress
|
Undecided
|
Michał Cłapiński |
Changed in opencontrail: | |
assignee: | nobody → Michał Cłapiński (michal.clapinski) |
status: | New → In Progress |
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #1 |
OpenContrail Admin (ci-admin-f) wrote : | #2 |
Review in progress for https:/
Submitter: Micha? C?api?ski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #3 |
Review in progress for https:/
Submitter: Micha? C?api?ski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #4 |
Review in progress for https:/
Submitter: Micha? C?api?ski (<email address hidden>)
2 comments hidden Loading more comments | view all 182 comments |
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #7 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit e40146ee7322cc9
Author: Michal Clapinski <email address hidden>
Date: Wed Oct 31 19:36:38 2018 +0100
Remove unused code
Change-Id: I034ef3b128f3a5
Partial-Bug: #1800894
OpenContrail Admin (ci-admin-f) wrote : | #8 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit f084fef6a738f0b
Author: Michal Clapinski <email address hidden>
Date: Wed Oct 31 19:11:01 2018 +0100
Remove old leftover pragmas
Change-Id: Icadb1935596cf7
Partial-Bug: #1800894
OpenContrail Admin (ci-admin-f) wrote : | #9 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit 70383222ea79372
Author: Michal Clapinski <email address hidden>
Date: Wed Oct 31 19:14:10 2018 +0100
Fix warnings and treat warning as errors
Change-Id: I4ad042b1e82c50
Partial-Bug: #1800894
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #10 |
Review in progress for https:/
Submitter: Micha? C?api?ski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #11 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit d1ef3dc9fecfb81
Author: Michał Cłapiński <email address hidden>
Date: Tue Nov 6 10:40:24 2018 +0100
Fix undefined reference
Because of lack of a gate job, two changes merged that broke the master.
This change should fix it.
Change-Id: I6aadac70bc0c2f
Partial-Bug: #1800894
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #12 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
1 comments hidden Loading more comments | view all 182 comments |
OpenContrail Admin (ci-admin-f) wrote : | #14 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #15 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
1 comments hidden Loading more comments | view all 182 comments |
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #17 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit 220c131c1fe48f9
Author: Mateusz Jablonski <email address hidden>
Date: Fri Dec 7 10:46:40 2018 +0100
Fix compilation warnings for 'io' and 'sandesh'
- Add explicit casting where needed
- Change types
- Change friend function to templated function
- Fix whitespaces at end of lines
Change-Id: I3cb98e20e0d0bb
Partial-Bug: #1800894
OpenContrail Admin (ci-admin-f) wrote : | #18 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit a61610d3055fd14
Author: Mateusz Jablonski <email address hidden>
Date: Mon Dec 10 10:19:47 2018 +0100
Fix compilation warnings for 'base' directory
Change-Id: Id12cabee2bf52f
Partial-Bug: #1800894
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #19 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #20 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #21 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #22 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #23 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit 4c1c07f1ac62916
Author: Mateusz Jablonski <email address hidden>
Date: Thu Dec 13 14:01:24 2018 +0100
Split flow management to multiple files
Change-Id: I7b9591584f9592
Partial-Bug: #1800894
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #24 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #25 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #26 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit 5e87ecf2135a79e
Author: Mateusz Jablonski <email address hidden>
Date: Fri Dec 21 14:40:25 2018 +0100
Fix most of level 1 warnings on Windows
- Invalid escape sequence
- Invalid unused field and getter
- Invalid preprocessor usage
- Wrong type of field
- Missing return in non-void returning functions
Change-Id: Id54b649f328451
Partial-Bug: #1800894
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #27 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #28 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #29 |
Review in progress for https:/
Submitter: Michal Clapinski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #30 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #31 |
Review in progress for https:/
Submitter: Michal Clapinski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #32 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #33 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #34 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #35 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #36 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #37 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit 68241e3400d6092
Author: Mateusz Jablonski <email address hidden>
Date: Fri Dec 21 14:52:56 2018 +0100
Fix warning related to not called destructor
Change-Id: Ic30b29e43ec7d1
Partial-Bug: #1800894
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #38 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #39 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #40 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
102 comments hidden Loading more comments | view all 182 comments |
OpenContrail Admin (ci-admin-f) wrote : | #143 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #144 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #145 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #146 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #147 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #148 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #149 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit 657ae7db3fd48ac
Author: Mateusz Jablonski <email address hidden>
Date: Thu Apr 18 15:30:04 2019 +0200
Fix formatting in dp-core
Change-Id: I821e2974c4bf64
Partial-Bug: #1800894
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #150 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #151 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #152 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #153 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #154 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #155 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit 1b448d4c471b7be
Author: Mateusz Jablonski <email address hidden>
Date: Tue Apr 9 17:39:19 2019 +0200
Remove code duplication from generate_
Introduce generate_
move code responsible for method body generation there.
Change-Id: I38c076320afc4c
Partial-Bug: #1800894
OpenContrail Admin (ci-admin-f) wrote : | #156 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit 1abaa4ef883c877
Author: Mateusz Jablonski <email address hidden>
Date: Thu Apr 18 12:06:12 2019 +0200
Fix warning about returning int when bool is expected
Change-Id: I8173095c1855c8
Partial-Bug: #1800894
OpenContrail Admin (ci-admin-f) wrote : | #157 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit ff0d194b186d0b7
Author: Mateusz Jablonski <email address hidden>
Date: Tue Apr 23 16:38:26 2019 +0200
Fix formatting in all '.sandesh' files in contrail-analytics
Change-Id: I59e008119f0ca2
Partial-Bug: #1800894
OpenContrail Admin (ci-admin-f) wrote : | #158 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit e817052afaa728a
Author: Mateusz Jablonski <email address hidden>
Date: Thu Apr 11 14:54:47 2019 +0200
Fix warning C4065 in t_cpp_generator for Windows
Fix `Switch statement contains 'default' but
no 'case' labels` by generating just the contents
of 'default' case when there is no other 'case' labels
instead of 'switch' with just 'default' label.
Change-Id: Ief8f75b144b8f6
Partial-Bug: #1800894
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #159 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #160 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #161 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #162 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #163 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #164 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #165 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #166 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit 85826146e9a964a
Author: Mateusz Jablonski <email address hidden>
Date: Tue Apr 16 16:19:19 2019 +0200
Fix warnings C4311 and C4312 on Windows
Fix warnings about pointer <-> type conversions
which may cause truncation. Use boost::any instead.
Change-Id: I056fc9c9d74784
Partial-Bug: #1800894
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #167 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #168 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit b108a458016fb1d
Author: Mateusz Jablonski <email address hidden>
Date: Tue Apr 23 16:27:05 2019 +0200
Fix 'struct' <-> 'class' mismatch
Declare ConfigClientOptions as a struct because it
is defined as a struct in other part of the code.
Change-Id: I9f8ffba7331faa
Partial-Bug: #1800894
OpenContrail Admin (ci-admin-f) wrote : | #169 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit f6d48acaec30823
Author: Mateusz Jablonski <email address hidden>
Date: Mon Apr 15 11:31:56 2019 +0200
Disable incorrectly generated warning C4724: Potential mod by 0
Change-Id: Iff8940e3c80932
Partial-Bug: #1800894
OpenContrail Admin (ci-admin-f) wrote : | #170 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit 348303c74d9956c
Author: Mateusz Jablonski <email address hidden>
Date: Wed Apr 17 16:51:05 2019 +0200
Fix warning C4099 in contrail-controller
Fix 'An object declared as a structure is defined as a class,
or an object declared as a class is defined as a structure'.
Change-Id: I1bbbf041f65306
Partial-Bug: #1800894
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #171 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #172 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit 4ece1c4d9ddbf3d
Author: Mateusz Jablonski <email address hidden>
Date: Tue Apr 23 16:41:11 2019 +0200
Fix formatting in all '.sandesh' files in contrail-controller
Change-Id: Id294563e83b044
Partial-Bug: #1800894
OpenContrail Admin (ci-admin-f) wrote : | #173 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit de1940505d030a5
Author: Mateusz Jablonski <email address hidden>
Date: Tue Apr 23 16:25:07 2019 +0200
Fix formatting in all '.sandesh' files in contrail-common
Change-Id: Ic3658cca85cb78
Partial-Bug: #1800894
OpenContrail Admin (ci-admin-f) wrote : | #174 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit f9f45667d75051f
Author: Mateusz Jablonski <email address hidden>
Date: Thu Apr 11 16:16:51 2019 +0200
Fix warning C4065 in process_signal for Windows
1. Fix `Switch statement contains 'default' but no 'case' labels`.
2. Move all OS-specific code to platform-specific files.
Change-Id: I653dffc1fd01ce
Partial-Bug: #1800894
OpenContrail Admin (ci-admin-f) wrote : | #175 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit ae99fe09db37028
Author: Mateusz Jablonski <email address hidden>
Date: Fri Apr 12 15:28:19 2019 +0200
Fix formatting in sandesh/library/cpp
Change-Id: I7188a787db5593
Partial-Bug: #1800894
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #176 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #177 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #178 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit 0f3307f595ff1e0
Author: Mateusz Jablonski <email address hidden>
Date: Wed Apr 17 11:08:37 2019 +0200
Fix warning about returning no value from function that should return
Change-Id: Icf1912b61d3b95
Partial-Bug: #1800894
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #179 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #180 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #181 |
Review in progress for https:/
Submitter: Przemys?aw Marcinkiewicz (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #182 |
Review in progress for https:/
Submitter: Mateusz Jablonski (<email address hidden>)
Review in progress for https:/ /review. opencontrail. org/47400
Submitter: Micha? C?api?ski (<email address hidden>)