Generating fencing from capitalized MAC returns nothing

[David Vallee Delisle]

Description
===========
When deploying using instackenv.json with capitalized MAC, the ports are created with lower case. When we later generate fencing, nothing is returned

Steps to reproduce
==================
* Use capitalized MACs in instackenv.json
* Deploy environment
* openstack overcloud generate fencing --ipmi-lanplus --ipmi-level administrator --output fencing.yaml instackenv.json

Expected result
===============
We should have a populated fencing.yaml file

Actual result
=============
File is empty.

This is the port list after deployment:
+--------------------------------------+-------------------+
| UUID | Address |
+--------------------------------------+-------------------+
| dd295dab-c162-496f-ac67-da8e53587237 | f4:e9:d4:72:a7:2e |
| 0ae89236-e5b4-40bd-bc19-9cb4e7a224b5 | f4:e9:d4:72:a9:14 |
| 839443dd-6d54-4336-a751-8839294349a8 | f4:e9:d4:ed:fa:32 |
| 49bbe677-b958-4d1c-bfc0-49152eff4dcd | f4:e9:d4:ed:f9:90 |
| 5225e0fd-b37d-4dff-91f7-4817f724f10d | f4:e9:d4:72:a9:b6 |
+--------------------------------------+-------------------+

Environment
===========
1. Exact version of OpenStack you are running.

Queens

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/614498

[OpenStack Infra (hudson-openstack)]

Change abandoned by Chris Jones (<email address hidden>) on branch: master
Review: https://review.openstack.org/614498
Reason: dvd already posted https://review.openstack.org/#/c/613990

[Chris Jones (cmsj)]

Apologies dvd, I missed that you'd already posted a patch at https://review.openstack.org/#/c/613990

[David Vallee Delisle (valleedelisle)]

Thanks for the contribution Chris!

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/613990
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=84603a06af326fbc4ca09fa7c28d9a44a80f1f42
Submitter: Zuul
Branch: master

commit 84603a06af326fbc4ca09fa7c28d9a44a80f1f42
Author: David Vallee Delisle <email address hidden>
Date: Mon Oct 29 12:53:57 2018 -0400

    Generating fencing for capitalized MACs

    Because the ports are stored in lower case, we need to use lower case
    MACs as our search key.

    Change-Id: I7e3727987265ef5222c95678c69cc4a50176dd16
    Closes-Bug: #1800504

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/619725

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/619725
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=7d609f111ad18c47cb84552826ca13ee60f83f35
Submitter: Zuul
Branch: stable/rocky

commit 7d609f111ad18c47cb84552826ca13ee60f83f35
Author: David Vallee Delisle <email address hidden>
Date: Mon Oct 29 12:53:57 2018 -0400

    Generating fencing for capitalized MACs

    Because the ports are stored in lower case, we need to use lower case
    MACs as our search key.

    Change-Id: I7e3727987265ef5222c95678c69cc4a50176dd16
    Closes-Bug: #1800504
    (cherry picked from commit 84603a06af326fbc4ca09fa7c28d9a44a80f1f42)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/625203

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/625203
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=5f93512ba90d68dc28d8c41b0052ff311b95c8a7
Submitter: Zuul
Branch: stable/queens

commit 5f93512ba90d68dc28d8c41b0052ff311b95c8a7
Author: David Vallee Delisle <email address hidden>
Date: Mon Oct 29 12:53:57 2018 -0400

    Generating fencing for capitalized MACs

    Because the ports are stored in lower case, we need to use lower case
    MACs as our search key.

    NB: cherry-pick is not entirely clean because we do not want to backport
    I74d4178dbb0cfe8c934ce15e3e7c9bb1c469de10
    (enrich-ironic-networking-integration) to queens

    Change-Id: I7e3727987265ef5222c95678c69cc4a50176dd16
    Closes-Bug: #1800504
    (cherry picked from commit 84603a06af326fbc4ca09fa7c28d9a44a80f1f42)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 10.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 8.6.7 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 9.5.0 release.