Money summary is missing on user Bills tab when no transactions are open

Bug #1800484 reported by Jason Boyer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
3.1
Fix Released
Low
Unassigned
3.2
Fix Released
Low
Unassigned

Bug Description

Eg 3.1.6, 3.2.1

The summary totals at the top of the bills screen are not displayed at all if the user has no open transactions. Visually I would expect all 3 to display $0.00 in this case rather than be missing entirely. Since no row is returned from money.open_user_summary if there are no open transactions to display, the template can just substitute a 0 if these fields are undefined. A branch is coming soon.

Revision history for this message
Jason Boyer (jboyer) wrote :

Here it is:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1800484_bill_totals working/user/jboyer/lp1800484_bill_totals

Testing is simple. Pre-patch, load 2 users (one with open transactions and one without) and compare the Totals fields at the top. The user with open transactions has entries for the total amounts owed and paid, and balance owed. The user with no open transactions has empty space there.

Post patch, open the same 2 accounts. Now both users have accurate Totals at the top.

tags: added: pullrequest
Changed in evergreen:
assignee: nobody → Rogan Hamby (rogan-hamby)
Revision history for this message
Rogan Hamby (rogan-hamby) wrote :

Worked for me. Sign off at user/rogan/lp1800484_signoff

Changed in evergreen:
assignee: Rogan Hamby (rogan-hamby) → nobody
tags: added: signedoff
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master, rel_3_3, rel_3_2, and rel_3_1. Thanks, Jason and Rogan!

Changed in evergreen:
importance: Undecided → Low
status: New → Confirmed
milestone: none → 3.3.3
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.