Updating metadata when filtering existing ones will have a problem

Bug #1800435 reported by Wangliangyu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Wangliangyu

Bug Description

1.Open one updating metadata page, like flavor's;
2.Add two custom metadatas, like m1='v1' and m2='';

Now, the submit button is gray.

3.Filter existing metadata [m1], and only m1 leaved right side.

Now, the submit button is green and could be submitted.

4.Submit

Now, the item's metadata is m1=v1 and m2=null.

In above, the submit button could not be changed whether filtering.

Wangliangyu (wangly)
summary: - Updating metadata when filtering existing onws will have a problem
+ Updating metadata when filtering existing ones will have a problem
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/613872

Changed in horizon:
assignee: nobody → Wangliangyu (wangly)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/613872
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=18a882809ae995031d82de528ecb9b822feab443
Submitter: Zuul
Branch: master

commit 18a882809ae995031d82de528ecb9b822feab443
Author: wangliangyu <email address hidden>
Date: Mon Oct 29 17:14:51 2018 +0800

    The metadata submit button ignore filtering

    The updated metadatas must have a value when updating.
    Otherwise the submit button will be disabled.
    But, if we filter out those ones without value, the button is okay.
    This problem becauses those filtered out metadatas were removed.
    Now, we just hidden them.

    Change-Id: Ia9272b9b054280c0ee55d6ab9aea18a6f0006f6b
    Closes-Bug: #1800435

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 15.0.0.0b2

This issue was fixed in the openstack/horizon 15.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.