znetconf --help or --version will return an error if /sys/bus/ccwgroup does not exist

[John George]

Regression of bug 1683507

With s390-tools-2.6.0-0ubuntu7 znetconf will return an error when passed informational request options such as --version or --help when /sys/bus/ccwgroup does not exist.

ubuntu@cosmicKVM:~$ apt-cache policy s390-tools
s390-tools:
  Installed: 2.6.0-0ubuntu7
  Candidate: 2.6.0-0ubuntu7
  Version table:
 *** 2.6.0-0ubuntu7 500
        500 http://us.ports.ubuntu.com/ubuntu-ports cosmic/main s390x Packages
        100 /var/lib/dpkg/status

ubuntu@cosmicKVM:~$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 18.10
Release: 18.10
Codename: cosmic

ubuntu@cosmicKVM:~$ strace /sbin/znetconf
execve("/sbin/znetconf", ["/sbin/znetconf"], 0x3ffcf87e630 /* 20 vars */) = 0
brk(NULL) = 0x2aa378b6000
access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory)
mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x3ff89bfc000
access("/etc/ld.so.preload", R_OK) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 3
fstat(3, {st_mode=S_IFREG|0644, st_size=47605, ...}) = 0
mmap(NULL, 47605, PROT_READ, MAP_PRIVATE, 3, 0) = 0x3ff89b00000
close(3) = 0
access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/lib/s390x-linux-gnu/libtinfo.so.6", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\2\1\0\0\0\0\0\0\0\0\0\0\3\0\26\0\0\0\1\0\0\0\0\0\0\327\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0644, st_size=182968, ...}) = 0
mmap(NULL, 186608, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x3ff89a80000
mmap(0x3ff89aa9000, 20480, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x28000) = 0x3ff89aa9000
close(3) = 0
access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/lib/s390x-linux-gnu/libdl.so.2", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\2\1\0\0\0\0\0\0\0\0\0\0\3\0\26\0\0\0\1\0\0\0\0\0\0\20\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0644, st_size=14552, ...}) = 0
mmap(NULL, 16728, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x3ff89a00000
mmap(0x3ff89a03000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x2000) = 0x3ff89a03000
close(3) = 0
access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/lib/s390x-linux-gnu/libc.so.6", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\2\1\3\0\0\0\0\0\0\0\0\0\3\0\26\0\0\0\1\0\0\0\0\0\2B\240"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0755, st_size=1694024, ...}) = 0
mmap(NULL, 1701816, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x3ff89800000
mmap(0x3ff89996000, 24576, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x195000) = 0x3ff89996000
mmap(0x3ff8999c000, 14264, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x3ff8999c000
close(3) = 0
mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x3ff89bfa000
mprotect(0x3ff89996000, 16384, PROT_READ) = 0
mprotect(0x3ff89a03000, 4096, PROT_READ) = 0
mprotect(0x3ff89aa9000, 16384, PROT_READ) = 0
mprotect(0x2aa05020000, 20480, PROT_READ) = 0
mprotect(0x3ff89ba4000, 4096, PROT_READ) = 0
munmap(0x3ff89b00000, 47605) = 0
openat(AT_FDCWD, "/dev/tty", O_RDWR|O_NONBLOCK) = 3
close(3) = 0
brk(NULL) = 0x2aa378b6000
brk(0x2aa378d7000) = 0x2aa378d7000
openat(AT_FDCWD, "/usr/lib/locale/locale-archive", O_RDONLY|O_CLOEXEC) = 3
fstat(3, {st_mode=S_IFREG|0644, st_size=5694416, ...}) = 0
mmap(NULL, 5694416, PROT_READ, MAP_PRIVATE, 3, 0) = 0x3ff89280000
close(3) = 0
getuid() = 1000
getgid() = 1000
geteuid() = 1000
getegid() = 1000
rt_sigprocmask(SIG_BLOCK, NULL, [], 8) = 0
ioctl(-1, TIOCGPGRP, 0x3fff237e84c) = -1 EBADF (Bad file descriptor)
sysinfo({uptime=2144, loads=[0, 5984, 7104], totalram=1894744064, freeram=674770944, sharedram=253952, bufferram=86081536, totalswap=395096064, freeswap=395096064, procs=104, totalhigh=0, freehigh=0, mem_unit=1}) = 0
rt_sigaction(SIGCHLD, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=SA_RESTART}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0
rt_sigaction(SIGCHLD, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=SA_RESTART}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=SA_RESTART}, 8) = 0
rt_sigaction(SIGINT, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0
rt_sigaction(SIGINT, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0
rt_sigaction(SIGQUIT, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0
rt_sigaction(SIGQUIT, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0
rt_sigaction(SIGTSTP, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0
rt_sigaction(SIGTSTP, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0
rt_sigaction(SIGTTIN, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0
rt_sigaction(SIGTTIN, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0
rt_sigaction(SIGTTOU, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0
rt_sigaction(SIGTTOU, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0
rt_sigprocmask(SIG_BLOCK, NULL, [], 8) = 0
rt_sigaction(SIGQUIT, {sa_handler=SIG_IGN, sa_mask=[], sa_flags=0}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0
uname({sysname="Linux", nodename="cosmicKVM", ...}) = 0
stat("/home/ubuntu", {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0
stat(".", {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0
stat("/home", {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0
stat("/home/ubuntu", {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0
getpid() = 5365
openat(AT_FDCWD, "/usr/lib/s390x-linux-gnu/gconv/gconv-modules.cache", O_RDONLY) = 3
fstat(3, {st_mode=S_IFREG|0644, st_size=26648, ...}) = 0
mmap(NULL, 26648, PROT_READ, MAP_SHARED, 3, 0) = 0x3ff89b00000
close(3) = 0
getppid() = 5363
getpid() = 5365
getpgrp() = 5363
ioctl(2, TIOCGPGRP, [5363]) = 0
rt_sigaction(SIGCHLD, {sa_handler=0x2aa04f5f788, sa_mask=[], sa_flags=SA_RESTART}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=SA_RESTART}, 8) = 0
prlimit64(0, RLIMIT_NPROC, NULL, {rlim_cur=7161, rlim_max=7161}) = 0
rt_sigprocmask(SIG_BLOCK, NULL, [], 8) = 0
openat(AT_FDCWD, "/sbin/znetconf", O_RDONLY) = 3
stat("/sbin/znetconf", {st_mode=S_IFREG|0755, st_size=33014, ...}) = 0
ioctl(3, TCGETS, 0x3fff237e7e4) = -1 ENOTTY (Inappropriate ioctl for device)
lseek(3, 0, SEEK_CUR) = 0
read(3, "#!/bin/bash\n#\n# znetconf - Tool "..., 80) = 80
lseek(3, 0, SEEK_SET) = 0
prlimit64(0, RLIMIT_NOFILE, NULL, {rlim_cur=1024, rlim_max=1024*1024}) = 0
fcntl(255, F_GETFD) = -1 EBADF (Bad file descriptor)
dup2(3, 255) = 255
close(3) = 0
fcntl(255, F_SETFD, FD_CLOEXEC) = 0
fcntl(255, F_GETFL) = 0x8000 (flags O_RDONLY|O_LARGEFILE)
fstat(255, {st_mode=S_IFREG|0755, st_size=33014, ...}) = 0
lseek(255, 0, SEEK_CUR) = 0
read(255, "#!/bin/bash\n#\n# znetconf - Tool "..., 8192) = 8192
rt_sigprocmask(SIG_BLOCK, NULL, [], 8) = 0
pipe([3, 4]) = 0
rt_sigprocmask(SIG_BLOCK, [CHLD], [], 8) = 0
rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0
rt_sigprocmask(SIG_BLOCK, [INT CHLD], [], 8) = 0
lseek(255, -6082, SEEK_CUR) = 2110
clone(child_stack=NULL, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0x3ff89bfb040) = 5366
rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0
rt_sigaction(SIGCHLD, {sa_handler=0x2aa04f5f788, sa_mask=[], sa_flags=SA_RESTART}, {sa_handler=0x2aa04f5f788, sa_mask=[], sa_flags=SA_RESTART}, 8) = 0
close(4) = 0
read(3, "znetconf\n", 128) = 9
read(3, "", 128) = 0
close(3) = 0
rt_sigprocmask(SIG_BLOCK, [CHLD], [], 8) = 0
rt_sigaction(SIGINT, {sa_handler=0x2aa04f5bd10, sa_mask=[], sa_flags=0}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0
wait4(-1, [{WIFEXITED(s) && WEXITSTATUS(s) == 0}], 0, NULL) = 5366
rt_sigaction(SIGINT, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, {sa_handler=0x2aa04f5bd10, sa_mask=[], sa_flags=0}, 8) = 0
rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0
--- SIGCHLD {si_signo=SIGCHLD, si_code=CLD_EXITED, si_pid=5366, si_uid=1000, si_status=0, si_utime=0, si_stime=0} ---
wait4(-1, 0x3fff237d5c8, WNOHANG, NULL) = -1 ECHILD (No child processes)
sigreturn({mask=[]}) = 0
read(255, "LSZNET=/lib/s390-tools/lsznet.ra"..., 8192) = 8192
stat("/sbin/udevadm", {st_mode=S_IFREG|0755, st_size=605088, ...}) = 0
rt_sigprocmask(SIG_BLOCK, NULL, [], 8) = 0
pipe([3, 4]) = 0
rt_sigprocmask(SIG_BLOCK, [CHLD], [], 8) = 0
rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0
rt_sigprocmask(SIG_BLOCK, [INT CHLD], [], 8) = 0
lseek(255, -7859, SEEK_CUR) = 2443
clone(child_stack=NULL, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0x3ff89bfb040) = 5367
rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0
rt_sigaction(SIGCHLD, {sa_handler=0x2aa04f5f788, sa_mask=[], sa_flags=SA_RESTART}, {sa_handler=0x2aa04f5f788, sa_mask=[], sa_flags=SA_RESTART}, 8) = 0
close(4) = 0
read(3, "/sys\n", 128) = 5
read(3, "", 128) = 0
--- SIGCHLD {si_signo=SIGCHLD, si_code=CLD_EXITED, si_pid=5367, si_uid=1000, si_status=0, si_utime=0, si_stime=0} ---
wait4(-1, [{WIFEXITED(s) && WEXITSTATUS(s) == 0}], WNOHANG, NULL) = 5367
wait4(-1, 0x3fff237d650, WNOHANG, NULL) = -1 ECHILD (No child processes)
sigreturn({mask=[]}) = 0
close(3) = 0
rt_sigprocmask(SIG_BLOCK, [CHLD], [], 8) = 0
rt_sigaction(SIGINT, {sa_handler=0x2aa04f5bd10, sa_mask=[], sa_flags=0}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0
rt_sigaction(SIGINT, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, {sa_handler=0x2aa04f5bd10, sa_mask=[], sa_flags=0}, 8) = 0
rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0
read(255, "CCWGROUPBUS_DIR=$SYSFSDIR/bus/cc"..., 8192) = 8192
brk(0x2aa378f8000) = 0x2aa378f8000
read(255, " [ -e $DEVICE_UNGROUPFILE ]\n\tthe"..., 8192) = 8192
brk(0x2aa37919000) = 0x2aa37919000
read(255, "E=\"$d/card_type\"\n\t\t\tif [ ! -f $T"..., 8192) = 8192
stat("/lib/s390-tools/lsznet.raw", {st_mode=S_IFREG|0755, st_size=10812, ...}) = 0
stat("/sys/bus/ccwgroup", 0x3fff237df58) = -1 ENOENT (No such file or directory)
fcntl(1, F_GETFD) = 0
fcntl(1, F_DUPFD, 10) = 10
fcntl(1, F_GETFD) = 0
fcntl(10, F_SETFD, FD_CLOEXEC) = 0
dup2(2, 1) = 1
fcntl(2, F_GETFD) = 0
fstat(1, {st_mode=S_IFCHR|0620, st_rdev=makedev(136, 0), ...}) = 0
write(1, "znetconf: Error: There are no cc"..., 47znetconf: Error: There are no ccwgroup devices
) = 47
dup2(10, 1) = 1
fcntl(10, F_GETFD) = 0x1 (flags FD_CLOEXEC)
close(10) = 0
rt_sigprocmask(SIG_BLOCK, [CHLD], [], 8) = 0
rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0
exit_group(31) = ?
+++ exited with 31 +++

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2019-09-13 05:55 EDT-------
@CAN. The problem is solved with Ubuntu 19.10, Please check if this is true from your perspective. Many thanks in advance

[Frank Heimes (fheimes)]

This is now fixed with znetconf from s390-tools v2.10 and higher - hence fixed in Eoan that comes with v2.11.