Q > R ceph upgrade fails: SwiftFetchDirGetTempurl not set

[John Fulton]

openstack overcloud external-upgrade run \
    --stack qe-Cloud-0 \
    --tags ceph 2>&1
...
 u'TASK [set facts for swift back up of ceph-ansible fetch directory] *************',
 u'Wednesday 24 October 2018 08:15:57 -0400 (0:00:00.044) 0:00:35.267 ***** ',
 u'ok: [undercloud] => {"ansible_facts": {"new_ceph_ansible_tarball_name": "temporary_dir_new.tar.gz", "old_ceph_ansible_tarball_name": "temporary_dir_old.tar.gz", "swift_get_url": "", "swift_put_url": ""}, "cha
nged": false}',
 u'',
 u'TASK [attempt download of fetch directory tarball from swift backup] ***********',
 u'Wednesday 24 October 2018 08:15:57 -0400 (0:00:00.066) 0:00:35.333 ***** ',
 u' [WARNING]: Consider using the get_url or uri module rather than running curl.',
 u'If you need to use command because get_url or uri is insufficient you can add',
 u'warn=False to this command task or set command_warnings=False in ansible.cfg to',
 u'get rid of this message.',
 u'fatal: [undercloud]: FAILED! => {"changed": true, "cmd": "curl -s -o /tmp/temporary_dir_old.tar.gz -w \'%{http_code}\' -X GET \\"\\"", "delta": "0:00:00.712603", "end": "2018-10-24 08:15:58.510813", "msg": "n
on-zero return code", "rc": 3, "start": "2018-10-24 08:15:57.798210", "stderr": "", "stderr_lines": [], "stdout": "000", "stdout_lines": ["000"]}',
 u'...ignoring',
 u'',
 u'TASK [ensure we create a new fetch_directory or use the old fetch_directory] ***',
 u'Wednesday 24 October 2018 08:15:58 -0400 (0:00:00.923) 0:00:36.257 ***** ',
 u'fatal: [undercloud]: FAILED! => {"changed": false, "msg": "Received HTTP: 000 when attempting to GET from "}',
 u'',
 u'NO MORE HOSTS LEFT *************************************************************',
 u'',
 u'PLAY RECAP *********************************************************************',
 u'ceph-0 : ok=2 changed=0 unreachable=0 failed=0 ',
 u'ceph-1 : ok=2 changed=0 unreachable=0 failed=0 ',
 u'ceph-2 : ok=2 changed=0 unreachable=0 failed=0 ',
 u'compute-0 : ok=2 changed=0 unreachable=0 failed=0 ',
 u'compute-1 : ok=2 changed=0 unreachable=0 failed=0 ',
 u'controller-0 : ok=2 changed=0 unreachable=0 failed=0 ',
 u'controller-1 : ok=2 changed=0 unreachable=0 failed=0 ',
 u'controller-2 : ok=2 changed=0 unreachable=0 failed=0 ',
 u'undercloud : ok=32 changed=12 unreachable=0 failed=1 ',
 u'',
 u'Wednesday 24 October 2018 08:15:58 -0400 (0:00:00.052) 0:00:36.310 ***** ',
 u'=============================================================================== ']

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/613373

[OpenStack Infra (hudson-openstack)]

Change abandoned by Juan Antonio Osorio Robles (<email address hidden>) on branch: master
Review: https://review.openstack.org/613373
Reason: clearing up the gate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/614801

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/613373
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=d1619ed9eac7ebbf8d8efae1476e1981d0a980e4
Submitter: Zuul
Branch: master

commit d1619ed9eac7ebbf8d8efae1476e1981d0a980e4
Author: John Fulton <email address hidden>
Date: Thu Oct 25 12:41:21 2018 -0400

    Run Mistral workflow to make temporary Swift URLs on upgrade

    The create_swift_backup_container_plan workflow was getting run
    on overcloud deploy but not upgrade because it was called only
    on the task split for the clone_git_repo task. This patch ensures
    it is run regardless of if the call to clone_git_repo is necessary.
    The create_swift_backup_container_plan workflow is used by Ceph and
    Swift so in theory this was a bug for Swift upgrades too.

    Also, updates rename_ceph_ansible_fetch_directory.yaml's notify_zaqar
    task to send a meaningful message, as previously the workflow failed
    because it tried to reference a variable as if it were a task.

    Change-Id: Ifab82c9a5b0a206c14ae7976d2c1c7f0e9fa3d9d
    Closes-Bug: #1799945

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/614801
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=9a57702d5526212c4642a2012dba99223a87d9bb
Submitter: Zuul
Branch: stable/rocky

commit 9a57702d5526212c4642a2012dba99223a87d9bb
Author: John Fulton <email address hidden>
Date: Thu Oct 25 12:41:21 2018 -0400

    Run Mistral workflow to make temporary Swift URLs on upgrade

    The create_swift_backup_container_plan workflow was getting run
    on overcloud deploy but not upgrade because it was called only
    on the task split for the clone_git_repo task. This patch ensures
    it is run regardless of if the call to clone_git_repo is necessary.
    The create_swift_backup_container_plan workflow is used by Ceph and
    Swift so in theory this was a bug for Swift upgrades too.

    Also, updates rename_ceph_ansible_fetch_directory.yaml's notify_zaqar
    task to send a meaningful message, as previously the workflow failed
    because it tried to reference a variable as if it were a task.

    Change-Id: Ifab82c9a5b0a206c14ae7976d2c1c7f0e9fa3d9d
    Closes-Bug: #1799945
    (cherry picked from commit d1619ed9eac7ebbf8d8efae1476e1981d0a980e4)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 10.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 9.5.0 release.