pep8 is start to fails on undercloud.py:695:33: W605 invalid escape sequence for instack-undercloud

[Sofer Athlan-Guyot]

hi,

from looking at http://zuul.openstack.org/builds?job_name=openstack-tox-pep8&project=openstack%2Finstack-undercloud the pep8 job started to fail on 2018-10-23T12:15:06

current review affected:

  - https://review.openstack.org/611647
  - https://review.openstack.org/605755
  - https://review.openstack.org/613166

See for instance http://logs.openstack.org/66/613166/1/check/openstack-tox-pep8/5872b24/job-output.txt.gz#_2018-10-24_23_56_40_190769

[Sofer Athlan-Guyot (sofer-athlan-guyot)]

May be related to python becoming stricter on backslash:

 https://bugs.python.org/issue27364

and from https://docs.python.org/3/whatsnew/3.6.html#deprecated-python-behavior

A backslash-character pair that is not a valid escape sequence now generates a DeprecationWarning. Although this will eventually become a SyntaxError, that will not be for several Python releases. (Contributed by Emanuel Barry in bpo-27364.)

can't see what version of pip is used or what version has changed for that matter.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/613267

[OpenStack Infra (hudson-openstack)]

Change abandoned by Athlan-Guyot sofer (<email address hidden>) on branch: master
Review: https://review.openstack.org/613267
Reason: Let's abandon this as instack_undercloud is not used in master anymore. Patches should go directly in stable/* branches.

[Sofer Athlan-Guyot (sofer-athlan-guyot)]

So the patch first fails on tox then on lower-constraints (because of incompatibility between instack_undercloud os-client call and openstacksdk) and then on requirements tests.

Let's end this as instack_undercloud should be removed from master. Commit only in stable branches.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/613542

[Sofer Athlan-Guyot (sofer-athlan-guyot)]

arghh, try to nominate this for queens only series, but it doesn't render a new queens line as it did there https://bugs.launchpad.net/tripleo/+bug/1798553

If anybody can explain how to have that effect ?

Putting this back to in-progress until I know better.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Juan Antonio Osorio Robles (<email address hidden>) on branch: stable/queens
Review: https://review.openstack.org/613542
Reason: clearing up the gate to free up resources.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/613542
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=1c58cb1e8c3fb656bc134720f7446c35d82cbdfe
Submitter: Zuul
Branch: stable/queens

commit 1c58cb1e8c3fb656bc134720f7446c35d82cbdfe
Author: Sofer Athlan-Guyot <email address hidden>
Date: Thu Oct 25 12:55:50 2018 +0200

    Fix pep8 stricter requirement about backslash (W605)

    Python will become stricter about backslash requirement and all
    unknown escape sequence will be forbidden. PEP8 adjusted for that and
    raises a W605 error.

    Change-Id: Id9404f4e10bfa7b1b207a40f71832b269f7cfbb6
    Closes-Bug: #1799926

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/619048

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/619048
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=3a0e8ae21ba5c0f17b31ec99a2f85f751ae1d2b1
Submitter: Zuul
Branch: stable/pike

commit 3a0e8ae21ba5c0f17b31ec99a2f85f751ae1d2b1
Author: Sofer Athlan-Guyot <email address hidden>
Date: Thu Oct 25 12:55:50 2018 +0200

    Fix pep8 stricter requirement about backslash (W605)

    Python will become stricter about backslash requirement and all
    unknown escape sequence will be forbidden. PEP8 adjusted for that and
    raises a W605 error.

    Change-Id: Id9404f4e10bfa7b1b207a40f71832b269f7cfbb6
    Closes-Bug: #1799926
    (cherry picked from commit 1c58cb1e8c3fb656bc134720f7446c35d82cbdfe)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 8.4.7 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 7.4.15 release.