It's possible to get a non-null action.circ.xact_finish in the Web client -- even though the item hasn't been checked in

[Jane Sandberg]

Currently in our 3.1.2 system, one of our patron has an item out, and we wanted to renew it. However, when we attempted to renew it in the Web staff client, we kept getting the error message ACTION_CIRCULATION_NOT_FOUND. This was pretty bizarre, since we were able to see a circulation ID and all sorts of other info from action.circulation within the Items Out grid.

I suspect we got this error because this circulation had -- somewhere in its travels -- received a date in the xact_finish column. I know that this item had received our max_fines, and then had those fines voided -- maybe it happened sometime in then. It looks like the renewal code checks to make sure that column is null here: https://github.com/evergreen-library-system/Evergreen/blob/6c0e0d5efaa90dd22468127d6e7d5bf87bdff6c1/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm#L4029

So, I'm not sure what the actual bug is here, but the end result (not being able to renew these items from the items out grid) is not good.

I've attached a screenshot of the error message we got.

[Jason Stephenson (jstephenson)]

Jane, what is the value of the checkin_time and checkin_scan_time fields? If they are null, then the bug is that your transaction got xact_finish set while it was still checked out. xact_finish is used as a surrogate for the checkin_time and to indicate that all bills have been paid, etc.

[Jane Sandberg (sandbergja)]

Jason, thanks for the troubleshooting advice! You're right, the checkin_time and checkin_scan_time fields are both null. I'm changing the name of this bug, and will try to figure out how reproduce this particular bug.