reproducer-quickstart fails to get dlrn_hash_tag_newest in the generated env file

[Sofer Athlan-Guyot]

Hi,

in that review[1] dlrn_hash_tag_newest is set. We can see in the reproducer script that it is taken into account[2]:

   EXTRA_VARS="$EXTRA_VARS --extra-vars dlrn_hash_tag_newest=ff0dd4aeed651e6db1f38cd0453d1c1656f4fbea_d8808f8b "

But in the generated file on the test node (env_vars_to_src.sh) we end up with:

    export EXTRA_VARS="$EXTRA_VARS --extra-vars dlrn_hash_tag=965941f1e62cef16967e7a7cd6d98263e52acb62_0989b280 "

and no reference to the dlrn_hash_tag_newest.

[1] https://review.openstack.org/#/c/604706/
[2] http://logs.openstack.org/06/604706/30/check/tripleo-ci-centos-7-standalone-upgrade/29966b7/logs/reproducer-quickstart.sh

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/612955

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/612955
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=9f226515351d764072dd57e4ae14a8bdfa94c582
Submitter: Zuul
Branch: master

commit 9f226515351d764072dd57e4ae14a8bdfa94c582
Author: Sofer Athlan-Guyot <email address hidden>
Date: Wed Oct 24 11:02:25 2018 +0200

    Fix EXTRA_VARS calculation for env_vars_to_source_file.

    Currently, even if dlrn_hash_tag_newest is found, it's not rendered in
    the env_vars_to_src.sh file.

    This fix it, and make the EXTRA_VARS line more readable.

    Change-Id: I604c7780ab7e37204360b74791b8522ff31ea695
    Closes-Bug: #1799662

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-quickstart-extras 2.1.1 release.