Missing __init__.py in masakari/tests/unit/cmd/

[Akhil jain]

There is missing __init__.py in masakari/tests/unit/cmd/ directory. On adding it, as I did in PS https://review.openstack.org/#/c/611836/ is causing failure in all the test in that directory.

Pasting error below:

Error:
==============================
Failed 4 tests - output below:
==============================

masakari.tests.unit.cmd.test_masakari_api.TestMasakariAPI.test_fails_if_none_started
------------------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    b'Traceback (most recent call last):'
    b' File "/home/ajain/github/masakari/.tox/py35/lib/python3.6/site-packages/mock/mock.py", line 1305, in patched'
    b' return func(*args, **keywargs)'
    b"TypeError: test_fails_if_none_started() missing 1 required positional argument: 'version_cache'"
    b''

masakari.tests.unit.cmd.test_masakari_api.TestMasakariAPI.test_continues_on_failure
-----------------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    b'Traceback (most recent call last):'
    b' File "/home/ajain/github/masakari/.tox/py35/lib/python3.6/site-packages/mock/mock.py", line 1305, in patched'
    b' return func(*args, **keywargs)'
    b"TypeError: test_continues_on_failure() missing 1 required positional argument: 'version_cache'"
    b''

masakari.tests.unit.cmd.test_masakari_api.TestMasakariAPI.test_fails_if_all_failed
----------------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    b'Traceback (most recent call last):'
    b' File "/home/ajain/github/masakari/.tox/py35/lib/python3.6/site-packages/mock/mock.py", line 1305, in patched'
    b' return func(*args, **keywargs)'
    b"TypeError: test_fails_if_all_failed() missing 1 required positional argument: 'version_cache'"
    b''

masakari.tests.unit.test_api_validation.PatternPropertiesTestCase.test_validate_patternProperties_fails
-------------------------------------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    b'Traceback (most recent call last):'
    b' File "/home/ajain/github/masakari/masakari/api/validation/validators.py", line 175, in validate'
    b' self.validator.validate(*args, **kwargs)'
    b' File "/home/ajain/github/masakari/.tox/py35/lib/python3.6/site-packages/jsonschema/validators.py", line 129, in validate'
    b' for error in self.iter_errors(*args, **kwargs):'
    b' File "/home/ajain/github/masakari/.tox/py35/lib/python3.6/site-packages/jsonschema/validators.py", line 105, in iter_errors'
    b' for error in errors:'
    b' File "/home/ajain/github/masakari/.tox/py35/lib/python3.6/site-packages/jsonschema/_validators.py", line 14, in patternProperties'
    b' if re.search(pattern, k):'
    b' File "/home/ajain/github/masakari/.tox/py35/lib/python3.6/re.py", line 182, in search'
    b' return _compile(pattern, flags).search(string)'
    b'TypeError: expected string or bytes-like object'
    b''
    b'During handling of the above exception, another exception occurred:'
    b''
    b'Traceback (most recent call last):'
    b' File "/home/ajain/github/masakari/masakari/tests/unit/test_api_validation.py", line 100, in check_validation_error'
    b' method(body=body, req=req,)'
    b' File "/home/ajain/github/masakari/masakari/api/validation/__init__.py", line 54, in wrapper'
    b" schema_validator.validate(kwargs['body'])"
    b' File "/home/ajain/github/masakari/masakari/api/validation/validators.py", line 192, in validate'
    b' raise exception.ValidationError(detail=detail)'
    b'masakari.exception.ValidationError: expected string or bytes-like object'
    b''
    b'During handling of the above exception, another exception occurred:'
    b''
    b'Traceback (most recent call last):'
    b' File "/home/ajain/github/masakari/masakari/tests/unit/test_api_validation.py", line 278, in test_validate_patternProperties_fails'
    b' expected_detail=detail)'
    b' File "/home/ajain/github/masakari/masakari/tests/unit/test_api_validation.py", line 108, in check_validation_error'
    b" 'Exception details did not match expected')"
    b' File "/home/ajain/github/masakari/.tox/py35/lib/python3.6/site-packages/testtools/testcase.py", line 411, in assertEqual'
    b' self.assertThat(observed, matcher, message)'
    b' File "/home/ajain/github/masakari/.tox/py35/lib/python3.6/site-packages/testtools/testcase.py", line 498, in assertThat'
    b' raise mismatch_error'
    b"testtools.matchers._impl.MismatchError: 'expected string or buffer' != 'expected string or bytes-like object': Exception details did not match expected"
    b''

======
Totals
======
Ran: 707 tests in 9.0673 sec.
 - Passed: 700
 - Skipped: 3
 - Expected Fail: 0
 - Unexpected Success: 0
 - Failed: 4
Sum of execute time for each test: 24.1502 sec.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/616084

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/616084
Committed: https://git.openstack.org/cgit/openstack/masakari/commit/?id=d8bb02ce0e59433c57087bc2975d71105c102da1
Submitter: Zuul
Branch: master

commit d8bb02ce0e59433c57087bc2975d71105c102da1
Author: tpatil <email address hidden>
Date: Wed Nov 7 15:52:28 2018 +0900

    Fix: TestMasakariAPI tests skipped due to missing __init__.py

    __init__.py was missing in `masakari.tests.unit.cmd` package, hence
    all tests under that package were skipped.

    This patch fixes all failing unit tests after adding __init__.py.

    Change-Id: I1a0133ff969260397158b0f3ebd7ca87439fd827
    Closes-Bug: #1799634

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/masakari 7.0.0.0b1 development milestone.