Upgrade fails on "Stop and disable cinder_api service" task.

[Sofer Athlan-Guyot]

Hi,

using the standalone upgrade jobs, we get that error[1]

2018-10-20 20:44:40 | 2018-10-20 20:44:40.633 93204 WARNING tripleoclient.v1.tripleo_upgrade.Upgrade [-] TASK [Stop and disable cinder_api service] *************************************
2018-10-20 20:44:40 | 2018-10-20 20:44:40.667 93204 WARNING tripleoclient.v1.tripleo_upgrade.Upgrade [-] fatal: [centos-7-ovh-gra1-0003260233]: FAILED! => {"msg": "The conditional check 'cinder_api_apache.rc == 0' failed. The error was: error while evaluating conditional (cinder_api_apache.rc == 0): 'dict object' has no attribute 'rc'\n\nThe error appears to have been in '/home/zuul/undercloud-ansible-teOBoO/Standalone/upgrade_tasks.yaml': line 528, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n when: cinder_api_enabled|bool\n - name: Stop and disable cinder_api service\n ^ here\n"}

[1] http://logs.openstack.org/06/604706/25/check/tripleo-ci-centos-7-standalone-upgrade/accb8de/logs/undercloud/home/zuul/standalone_upgrade.log.txt.gz#_2018-10-20_20_44_40

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/612279

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/612279
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=4ad99224bd655d85c6829e0c9d5653ef0837549f
Submitter: Zuul
Branch: master

commit 4ad99224bd655d85c6829e0c9d5653ef0837549f
Author: Sofer Athlan-Guyot <email address hidden>
Date: Mon Oct 22 10:25:31 2018 +0200

    Fix cinder_api_apache error during upgrade.

    In I35c8d9985df21b3084fba558687e1f408e5a0878 we removed the
    cinder_api_apache from step 2. This cause the upgrade to fail as the
    next task is using that variable.

    Converting it to a fact in step 0 so that we can call it later.

    Change-Id: I55058fd6288eec87fd1cd028b4a684b9472496cb
    Resolve-Bug: #1799166

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/612637

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/612637
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=c05b035cfc6fa264c21eed03fad7fa8d8f90b244
Submitter: Zuul
Branch: stable/rocky

commit c05b035cfc6fa264c21eed03fad7fa8d8f90b244
Author: Sofer Athlan-Guyot <email address hidden>
Date: Mon Oct 22 10:25:31 2018 +0200

    Fix cinder_api_apache error during upgrade.

    In I35c8d9985df21b3084fba558687e1f408e5a0878 we removed the
    cinder_api_apache from step 2. This cause the upgrade to fail as the
    next task is using that variable.

    Converting it to a fact in step 0 so that we can call it later.

    Change-Id: I55058fd6288eec87fd1cd028b4a684b9472496cb
    Resolve-Bug: #1799166
    (cherry picked from commit 4ad99224bd655d85c6829e0c9d5653ef0837549f)

[Sofer Athlan-Guyot (sofer-athlan-guyot)]

https://review.openstack.org/#/c/612637/ merged, not sure why lp didn't pick it up.