bundle opengl32sw.dll with Mixxx

[RJ Skerry-Ryan]

Follow-up to Bug #1786718. We could ensure that Mixxx will not crash at startup with Qt's dynamic OpenGL support enabled by bundling opengl32sw.dll. We can either build mesa ourselves or use pre-built DLLs from Qt.

[Daniel Schürmann (daschuer)]

Since this is a crasher fix it should be a requiment for a 2.2 release.

[Be (be.ing)]

This is a crasher? I don't see any reports of actual crashes in this bug. RJ's last comment in the old bug ( https://bugs.launchpad.net/mixxx/+bug/1786718/comments/20 ) said this remaining issue is not critical.

[RJ Skerry-Ryan (rryan)]

Notably it's a crash on startup, so not a "party stopper" per se. Adding
the OpenGLES DLLs mitigate the issue for real hardware and some VMs I
believe, so I think the only time this actually causes an issue is if the
user truly has no graphics card capable of OpenGL and software rendering is
needed. Because I don't think it affects anyone but us developers using
Mixxx in a VM that's why I put it as low priority :).

On Sun, Oct 28, 2018 at 8:30 AM Be <email address hidden> wrote:

> This is a crasher? I don't see any reports of actual crashes in this
> bug. RJ's last comment in the old bug (
> https://bugs.launchpad.net/mixxx/+bug/1786718/comments/20 ) said this
> remaining issue is not critical.
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1798858
>
> Title:
> bundle opengl32sw.dll with Mixxx
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1798858/+subscriptions
>

[Be (be.ing)]

Thank you for clarifying.

[Daniel Schürmann (daschuer)]

Isn't it only a matter of adding a dll to the installer?
What is the risk, not to do it in 2.2?

[RJ Skerry-Ryan (rryan)]

I see no risk in doing it for 2.2 if someone's motivated to fix this, I'm
only talking about priority.

On Sun, Oct 28, 2018 at 11:05 AM Daniel Schürmann <
<email address hidden>> wrote:

> Isn't it only a matter of adding a dll to the installer?
> What is the risk, not to do it in 2.2?
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1798858
>
> Title:
> bundle opengl32sw.dll with Mixxx
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1798858/+subscriptions
>

[Daniel Schürmann (daschuer)]

Do you have a recipe to do it?
I just had a look how you add libEGL.dll butI have no clue.

[RJ Skerry-Ryan (rryan)]

The fix won't be like for libEGL/etc. because Qt doesn't produce these DLLs.

Qt provides pre-built Windows DLLs here:
http://download.qt.io/development_releases/prebuilt/llvmpipe/windows/
which we could simply check-in to the buildserver environment repo, though these are quite old now. Mesa is at version 18.2.3 and the latest Qt provides is a 12.x RC.are on 12.x RC. I think it'd be ideal if we built Mesa from source in the buildserver repo, so the process is just like adding any other library (check in the source, add a build_xxx.bat, run it from build_environment.bat)

[Be (be.ing)]

I'm not comfortable making *any* change to the 2.2 build environments at this point unless it is needed to fix a critical bug.

[Daniel Schürmann (daschuer)]

The issue seems to effect more users, since QT has a blacklist of drivers.
So any system that is listed here will not have GL Waveforms:
https://github.com/qt/qtbase/blob/dev/src/plugins/platforms/windows/openglblacklists/default.json

[Daniel Schürmann (daschuer)]

If GL is blacklisted or < 2.1 Qt tries to use the angle driver for GL ES which translates direct 3 d.
It will currently crash, if this is blacklisted as well, because of the outdated GL detection code.
The cash will be fixed here:
https://bugs.launchpad.net/mixxx/+bug/1825461

Users can than use the CPU rendered waveforms only, which should be not worse than CPU rendered GL waveforms. The only remaining issue is, that they have no spinnies.

[Daniel Schürmann (daschuer)]

We can find the required DLLs here:
http://download.qt.io/development_releases/prebuilt/llvmpipe/windows/

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9473