Replace comma with semicolon in trace/simple.c
Bug #1798659 reported by
Oren Milman
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
QEMU |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
In the master branch in trace/simple.c in writeout_thread (https:/
dropped.
dropped.rec.pid = trace_pid;
It seems to me like a typo that the first line ends with a comma.
Currently this causes no harm, but I think this should be fixed.
Changed in qemu: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
It's perfect valid C to terminate a statement with "," instead of ";" - it just has a different meaning. Consider this:
#include <stdio.h>
int main()
printf( "Hello! \n"),
{
if (0)
printf("Good bye!\n");
return 0;
}
At a first glance, you'd expect this program to print "Good bye!" - but it does not. Actually, the "," is used here to put the two printf statements into the same block, so this program is the same as:
if (0) {
printf( "Hello! \n");
printf( "Good bye!\n");
}
Thus, there is no real bug in simple.c here, but of course it would be better style to clean this up and use ";" instead.
By the way, two lines earlier there is another line ending in ",":
dropped. rec.event = DROPPED_EVENT_ID,