Eeschema labels incorrectly validated

[Seth Hillbrand]

Steps:
1) Open Kicad, load demos/test_xil_95108/carte_test.pro
2) Open Eeschema
3) Edit the label "PAR_AUX3/SELECT*" on J1
4) Click OK

Warning message appears "'PAR_AUX3/SELECT*' is invalid". This does not happen in 5.0.1

Application: kicad
Version: (6.0.0-rc1-dev-950-ga5c892d9c-dirty), release build
Libraries:
    wxWidgets 3.0.2
Platform: Linux 4.9.0-8-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.62.0
    OpenCASCADE Community Edition: 6.8.0
    Compiler: GCC 6.3.0 with C++ ABI 1010

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=OFF
    KICAD_SCRIPTING_MODULES=OFF
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=OFF
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

I believe that's because we can't tell the difference between label "PAR_AUX3/SELECT*" and label "SELECT*" on sheet "PAR_AUX3".

[Seth Hillbrand (sethh)]

This regression breaks existing schematics in our demos folder. It will certainly break other people's schematics as well. We shouldn't be adding the limit now until we bump the schematic version.

[Jeff Young (jeyjey)]

See https://bugs.launchpad.net/kicad/+bug/1749232.

[Seth Hillbrand (sethh)]

Huh. Thanks!

Did we not have validation enabled in 5.0.x? Any ideas what the difference is?

[Jeff Young (jeyjey)]

I /think/ even in 4.0.7 we validated it in some places but not others. I thought 5.0 was uniform, but it's possible it just validated in more places and 5.1 does it uniformly.

I'm playing around with an escaping mechanism....

[Seth Hillbrand (sethh)]

I see the difference. In 5.0.x, we didn't allow input of the '/' character but you could still paste it and it wasn't checked on closing the dialog. In 5.1, we check on closing the dialog.

[Jeff Young (jeyjey)]

Here's a patch which escapes '/' characters in labels (and resulting netnames) and re-allows spaces (as they can come in through sheet names anyway). It uses the escaping mechanism Wayne and I discussed over email (which prioritizes readability over verbosity).

@Seth and @Wayne, if you get a chance could you try it out and let me know what you think?

[KiCad Janitor (kicad-janitor)]

Fixed in revision 684bb62fd8edb4785caee33b189d73e68921942f
https://git.launchpad.net/kicad/patch/?id=684bb62fd8edb4785caee33b189d73e68921942f