os_region_name settings deprecation broke IHA

[Michele Baldessari]

Via change f2e72352b1376ce719614e9cad4e4c71a3f9c3d8 we did the following:
diff --git a/puppet/services/nova-base.yaml b/puppet/services/nova-base.yaml
index f12b0d816dea..3e43b8cf7477 100644
--- a/puppet/services/nova-base.yaml
+++ b/puppet/services/nova-base.yaml
@@ -260,7 +260,7 @@ outputs:
           nova::placement::project_name: 'service'
           nova::placement::password: {get_param: NovaPassword}
           nova::placement::auth_url: {get_param: [EndpointMap, KeystoneInternal, uri_no_suffix]}
- nova::placement::os_region_name: {get_param: KeystoneRegion}
+ nova::placement::region_name: {get_param: KeystoneRegion}
           nova::placement::os_interface: {get_param: NovaPlacementAPIInterface}
           nova::database_connection:
             make_url:

But in the IHA script we looked for the os_region_name config key in the placemenet ini section of nova.conf. We need to adapt that script as well

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/611551
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=9235e30c0819d1283a55029f73b4d40fbe6625fe
Submitter: Zuul
Branch: master

commit 9235e30c0819d1283a55029f73b4d40fbe6625fe
Author: Michele Baldessari <email address hidden>
Date: Thu Oct 18 11:19:09 2018 +0200

    Fix IHA with the new region_name key

    ia change f2e72352b1376ce719614e9cad4e4c71a3f9c3d8 we did the following
    in nova-base.yaml:
    - nova::placement::os_region_name: {get_param: KeystoneRegion}
    + nova::placement::region_name: {get_param: KeystoneRegion}

    But in the IHA script we looked for the os_region_name config key in the
    placemenet ini section of nova.conf, which is now missing.
    We need to adapt that script as well. Without this fix we'll error
    out like this:
    Oct 16 09:08:12 overcloud-novacomputeiha-0 dockerd-current[14673]: File "/var/lib/nova/instanceha/check-run-nova-compute", line 147, in create_nova_connection
    Oct 16 09:08:12 overcloud-novacomputeiha-0 dockerd-current[14673]: region_name=options["os_region_name"][0],
    Oct 16 09:08:12 overcloud-novacomputeiha-0 dockerd-current[14673]: KeyError: 'os_region_name'

    Closes-Bug: #1798560

    Change-Id: I8906145955ab6c444efdfa73beca073a62c26e26

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/613258

[OpenStack Infra (hudson-openstack)]

Change abandoned by Juan Antonio Osorio Robles (<email address hidden>) on branch: stable/rocky
Review: https://review.openstack.org/613258
Reason: clearing up the gate to free up resources.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/613258
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=aab90490b705463004b8cfe644af934fff76da21
Submitter: Zuul
Branch: stable/rocky

commit aab90490b705463004b8cfe644af934fff76da21
Author: Michele Baldessari <email address hidden>
Date: Thu Oct 18 11:19:09 2018 +0200

    Fix IHA with the new region_name key

    ia change f2e72352b1376ce719614e9cad4e4c71a3f9c3d8 we did the following
    in nova-base.yaml:
    - nova::placement::os_region_name: {get_param: KeystoneRegion}
    + nova::placement::region_name: {get_param: KeystoneRegion}

    But in the IHA script we looked for the os_region_name config key in the
    placemenet ini section of nova.conf, which is now missing.
    We need to adapt that script as well. Without this fix we'll error
    out like this:
    Oct 16 09:08:12 overcloud-novacomputeiha-0 dockerd-current[14673]: File "/var/lib/nova/instanceha/check-run-nova-compute", line 147, in create_nova_connection
    Oct 16 09:08:12 overcloud-novacomputeiha-0 dockerd-current[14673]: region_name=options["os_region_name"][0],
    Oct 16 09:08:12 overcloud-novacomputeiha-0 dockerd-current[14673]: KeyError: 'os_region_name'

    Closes-Bug: #1798560

    Change-Id: I8906145955ab6c444efdfa73beca073a62c26e26
    (cherry picked from commit 9235e30c0819d1283a55029f73b4d40fbe6625fe)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.1.0 release.