Peer review role prevents site / institution admin from seeing all content on page during objectionable review

Bug #1798203 reported by Steven
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Kevin Dibble
18.10
Fix Released
Medium
Unassigned
19.04
Fix Released
Medium
Kevin Dibble

Bug Description

Bug Summary: Content author has a public portfolio page -> Another user reports objectionable material = author sees warning on page -> does not edit page but adds the site admin as a peer reviewer -> who can not see the page details but only the headings
-----------------------

Environment tested: Master
Browser tested: Chrome

Preconditions:
1. Content author creates a portfolio page
2. Another site user reports objectionable material on the page

Test Steps:
1. Content author does not change any content on the page
2. Content author shares the page with Site admin and assigns the role of peer for peer review
3. Content author notify site admin stuff has been changed
4. Site admin logs in and browses to the page with objectionable material

Actual result: The site admin only sees headings on the page and cannot see the actual page content

Expected result: Site admin should be able to see all page content even if they are assigned the role of peer for peer review or site admins should not be in the list of users that can do peer reviews

Tags: bite-sized
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

This is a tricky one. The site or institution admin can be peer assessor. In that role, they should only be able to see what the peer assessor is allowed to see.

However, when objectionable content is reported, the institution and site admin need to be able to see everything on the page that the portfolio author can see. That means any published peer assessments. They should not be able to see peer assessments that are in draft status as the portfolio author cannot see them either.

summary: - Peer review role prevents site admin from seeing all content on page
+ Peer review role prevents site / institution admin from seeing all
+ content on page during objectionable review
Changed in mahara:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Marked as medium because the portfolio author doesn't have to share their page with the admin in order to show that they fixed things. Also, the site admin can log in as the portfolio author if needed.

Changed in mahara:
milestone: none → 18.10rc2
Changed in mahara:
milestone: 18.10rc2 → 18.10.1
tags: added: bite-sized
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9656

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9656
Committed: https://git.mahara.org/mahara/mahara/commit/39d4428671c8292bb2c3335d869278753608ef58
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 39d4428671c8292bb2c3335d869278753608ef58
Author: Kevin Dibble <email address hidden>
Date: Mon Mar 25 16:48:28 2019 +1300

bug 1798203: Peer review prevents viewing objectionable content

Updated view to allow the user admin to view content if it has
reported objectionable content.

behatnotneeded

Change-Id: I277902b5a6121c5daaa6f692dcc391e9ef99caf8

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9862

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9862
Committed: https://git.mahara.org/mahara/mahara/commit/e535179c3ea3bce35316f2eba5137b1822a3f568
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit e535179c3ea3bce35316f2eba5137b1822a3f568
Author: Kevin Dibble <email address hidden>
Date: Mon Mar 25 16:48:28 2019 +1300

bug 1798203: Peer review prevents viewing objectionable content

Updated view to allow the user admin to view content if it has
reported objectionable content.

behatnotneeded

Change-Id: I277902b5a6121c5daaa6f692dcc391e9ef99caf8
(cherry picked from commit 39d4428671c8292bb2c3335d869278753608ef58)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9863

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9863
Committed: https://git.mahara.org/mahara/mahara/commit/2f09502049ae50ca06b6b1ffa4645bce0cb8def5
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit 2f09502049ae50ca06b6b1ffa4645bce0cb8def5
Author: Kevin Dibble <email address hidden>
Date: Mon Mar 25 16:48:28 2019 +1300

bug 1798203: Peer review prevents viewing objectionable content

Updated view to allow the user admin to view content if it has
reported objectionable content.

behatnotneeded

Change-Id: I277902b5a6121c5daaa6f692dcc391e9ef99caf8
(cherry picked from commit 39d4428671c8292bb2c3335d869278753608ef58)
(cherry picked from commit e535179c3ea3bce35316f2eba5137b1822a3f568)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.