the interface always sets "{endpoint_name}.database.changed" even when nothing has changed

Bug #1798118 reported by Junien F
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pgsql Interface for charms.reactive
Fix Released
High
Unassigned

Bug Description

Hi,

requires.py does the following :

392 @when_not('endpoint.{endpoint_name}.joined')
393 def _departed(self):
394 self._clear_all_flags()
395 self._clear_flag('{endpoint_name}.database.changed')
396 self._set_flag('{endpoint_name}.database.changed')
397 self._clear_flag('{endpoint_name}.master.changed')
398 self._set_flag('{endpoint_name}.master.changed')
399 self._clear_flag('{endpoint_name}.standbys.changed')
400 self._set_flag('{endpoint_name}.standbys.changed')

meaning that when the relation is torn down, every hook invocation will have the .changed flags set, even though nothing changed (after the first hook runs). This is misleading / not really usable.

Thanks

Junien F (axino)
description: updated
Stuart Bishop (stub)
Changed in interface-pgsql:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Stuart Bishop (stub) wrote :

The .changed flag remains set indefinitely, but it no longer reset repeatedly and no longer triggers reactive triggers repeatedly.

Changed in interface-pgsql:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.