Webstaff - eg-org-selector directive's input will stretch to fill page width

[Cesar V]

As seem here https://launchpadlibrarian.net/392507379/Screenshot%20from%202018-10-09%2018-14-36.png (photo credit: Jason Stephenson/Dyrcona) and currently on the latest master.

In some UI's the new template for the OU selector will (new type-ahead one, created as a result of bug 1511742) will stretch to fill the screen instead of being a reasonable width. This is because the inner input element is styled by bootstrap's .form-control CSS rules, giving it a 100% width, but since the parent element is a span, it'll just expand. Adding a simple "display: inline-block" to the parent span, seems to fix the issue, though I'm sure there might be better ways to address this.

[Bill Erickson (berick)]

Indeed, several UI's were updated as part of bug #1511742 (https://bugs.launchpad.net/evergreen/+bug/1511742/comments/40). It looks like we missed one...

I think the .form-control expansion is what we want, since it's consistent with other Bootstrap form controls. That way the user has full control of the width, e.g. by wrapping the selector in "col-*" classes.

[Cesar V (cesardv)]

Ah I see what you mean Bill, thanks.

I guess I'll submit a branch here for the missed UI that lack an encompassing container for the eg-org-selector. So far I've only noticed the VolcopyEditor, but I'll do another pass to make sure there aren't others.

[Cesar V (cesardv)]

Here's a branch for some OU selectors that I found needed to be contained a bit.
There may be more in places I didn't think to look however...

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cesardv/lp1797973-eg-org-selector-container

[Terran McCanna (tmccanna)]

I'm getting a merge conflict when I try to cherry-pick this to current master.

[Mike Risher (mrisher)]

Apparently the issue shown in the screenshot has already been fixed at this point.

I tested the transit list admin interface, and see that the org selector is much narrower and looks better. I consent to sign off on this with my name Mike Risher and email <email address hidden>

[Michele Morgan (mmorgan)]

No longer an issue in 3.5 and 3.6.