[2.5b3, UI] UI incorrect action notifications that machine cannot be commissioned, deployed, etc.

[Andres Rodriguez]

The UI is now showing a notification incorrectly indicating that machines cannot be deployed (or commissioned, as it is a similar notification), while machines are correctly being deployed/commissioned.

See attached screenshot.

[Lilyana Videnova (lilyanavidenova)]

The notification should suggest that these machines cannot be deployed/commissioned again right now as they are in the middle of the process, which is not going to be interrupted, thus I suggest the notification should read:

"N nodes are currently being deployed | commissioned. To proceed, update your selection."

Which would correctly explain what is happening and why the user's action cannot be completed.

[Caleb Ellis (caleb-ellis)]

I've gone with adding a clause to the current message rather than changing the entire message: ", N of which is | are currently in the process". Otherwise, since you can select a few nodes, some of which are deploying, some of which aren't and then choose Deploy from the action menu, the message "N nodes are currently being deployed | commissioned" no longer makes sense. I tried adding two separate warnings, one for normal action errors and one for in progress errors but thought it looked a bit busy.

[Andres Rodriguez (andreserl)]

@Lilyana,

The error is not that machines cannot be deployed or commissioned. The error is that the message is being shown when the machines *can* be deployed and commissioned.

In other words, you can select 50 machines in 'Ready' state, all of which can be commissioned or deployed, and when you execute the action it *incorrectly* shows the message. The message should only be shown if one or more of the 50 selected machines are in a state that prevents them from being deployed/commissioned.

[Lilyana Videnova (lilyanavidenova)]

Just to make sure everyone is on the same page, there was a misunderstanding and the fix proposed is not required.

In order to fix this bug, we need to hide the warning message that is displayed _while_ one or more nodes are commissioned/deployed correctly and only display it if there is an actual problem commissioning/deploying a node.