Shading language version conversion to double fail

[Jukka Pakarinen]

Widelands does not work with finnish language option but 'en_US' works fine.

./widelands --language=fi_FI

Last two lines from console:

Graphics: OpenGL: ShadingLanguage: "1.30" (1,00)
ERROR: Shading language version is too old!

I think that atof conversion depends on locale. Decimal separator is comma character in finnish which might be the problem. My first guess, but not absolutely sure about that.

I compiled Widelands from trunk, revno 8883, on Debian 9.5.

[Notabilis (notabilis27)]

Thanks for the bug report.
We also got a related bug report on the forum for french locales:
https://wl.widelands.org/forum/topic/4237/?page=2#post-26398

atof() seems indeed to be the problem, I guess we have to replace it with something locale-independent.

[GunChleoc (gunchleoc)]

Thanks for confirming that the locale is the problem! I'll set my system locale to an affected language for testing now.

[Jukka Pakarinen (flegu)]

I tested revno 8890 and Widelands worked with the finnish language option. Thanks for fixing it!

[Jukka Pakarinen (flegu)]

I just noticed that this one was only a hotfix and the real fix is comming later.

[Notabilis (notabilis27)]

The real fix has been merged to trunk now. Can you test whether it works for you, please?

[Jukka Pakarinen (flegu)]

The real fix works as expected. Thanks!

[GunChleoc (gunchleoc)]

Fixed in build20-rc1