Octavia flavor isn't created if composable octavia

[Brent Eagles]

Related bug: https://bugzilla.redhat.com/show_bug.cgi?id=1637884

We create the octavia flavor for launching amphora in the worker controller template because that is the component that uses the flavor and it's arguably most tightly related to that service. We use docker_puppet_tasks to run the puppet to create the flavor at the appropriate time in the worker. However, it appears that the docker_puppet_tasks is only run on the bootstrap node, which seems to be the first controller (regardless of distribution of services). So in composable roles, the worker, health manager, etc are likely to be located "off-controller" and the flavor will never be created.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/609696
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=7d533b77370311926e23b18ef6dbdbf2c3dcac01
Submitter: Zuul
Branch: master

commit 7d533b77370311926e23b18ef6dbdbf2c3dcac01
Author: Brent Eagles <email address hidden>
Date: Thu Oct 11 10:34:48 2018 -0230

    Ensure octavia flavor gets configured if composable octavia

    The octavia service templates configure the octavia flavor through the
    controller-worker is deployed on a node other than the controller. Since
    this uses docker_puppet_tasks, it is only run on the bootstrap node
    which at the moment means the first controller. This patch moves the
    flavor creation to the docker API template to make sure the flavor gets
    created when deploying worker components in an non-standard role.

    Closes-Bug: #1797443

    Change-Id: Id823672b82ea60f355d1f01068f802567d687da5

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/618801

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/618805

[OpenStack Infra (hudson-openstack)]

Change abandoned by Juan Antonio Osorio Robles (<email address hidden>) on branch: stable/queens
Review: https://review.openstack.org/618805
Reason: Abandoning to save resources.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/618805
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=fb4bc626261cc85c3fee1eb99476b3d7fba03e52
Submitter: Zuul
Branch: stable/queens

commit fb4bc626261cc85c3fee1eb99476b3d7fba03e52
Author: Brent Eagles <email address hidden>
Date: Thu Oct 11 10:34:48 2018 -0230

    Ensure octavia flavor gets configured if composable octavia

    The octavia service templates configure the octavia flavor through the
    controller-worker is deployed on a node other than the controller. Since
    this uses docker_puppet_tasks, it is only run on the bootstrap node
    which at the moment means the first controller. This patch moves the
    flavor creation to the docker API template to make sure the flavor gets
    created when deploying worker components in an non-standard role.

    Conflicts:
        docker/services/octavia-api.yaml

    Closes-Bug: #1797443

    Change-Id: Id823672b82ea60f355d1f01068f802567d687da5
    (cherry picked from commit 7d533b77370311926e23b18ef6dbdbf2c3dcac01)
    (cherry picked from commit 130633422731630ebc0bcc45bb899cd7c0aa1bc3)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.1.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/618801
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=130633422731630ebc0bcc45bb899cd7c0aa1bc3
Submitter: Zuul
Branch: stable/rocky

commit 130633422731630ebc0bcc45bb899cd7c0aa1bc3
Author: Brent Eagles <email address hidden>
Date: Thu Oct 11 10:34:48 2018 -0230

    Ensure octavia flavor gets configured if composable octavia

    The octavia service templates configure the octavia flavor through the
    controller-worker is deployed on a node other than the controller. Since
    this uses docker_puppet_tasks, it is only run on the bootstrap node
    which at the moment means the first controller. This patch moves the
    flavor creation to the docker API template to make sure the flavor gets
    created when deploying worker components in an non-standard role.

    Conflicts:
        docker/services/octavia-api.yaml

    Closes-Bug: #1797443

    Change-Id: Id823672b82ea60f355d1f01068f802567d687da5
    (cherry picked from commit 7d533b77370311926e23b18ef6dbdbf2c3dcac01)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.2.0 release.