VM

Repetitive code block in vm-do-reply?

Bug #179738 reported by Robert Widhopf-Fenk
2
Affects Status Importance Assigned to Milestone
VM
Fix Released
Wishlist
Ulrich Müller

Bug Description

http://groups.google.com/group/gnu.emacs.vm.info/msg/cf94086e3487bd45

Newsgroups: gnu.emacs.vm.info
Subject: Repetitive code block in vm-do-reply?
From: blueman <email address hidden>
Message-ID: <email address hidden>

Related branches

Uday Reddy (reddyuday)
Changed in viewmail:
importance: Undecided → Wishlist
Ulrich Müller (ulm)
affects: viewmail → vm
Revision history for this message
Uday Reddy (reddyuday) wrote :

This is not a high priority right now.

Changed in vm:
status: New → Triaged
status: Triaged → Won't Fix
Uday Reddy (reddyuday)
Changed in vm:
status: Won't Fix → Triaged
assignee: nobody → Ulrich Müller (ulm)
milestone: none → 8.2.0-devo
Revision history for this message
Uday Reddy (reddyuday) wrote :

It seems that the second copy of the code block is covering up the error in the first code block.

If you are replying to a message with a "reply-to" header, then the first code block adds it to 'to' and the second code block becomes a no-op.

If you are reply to a message without a "reply-to" header, then the first code block adds a nil to 'to' and the second code block adds the "from" header. (If the first code block had done the job, then this would become a no-op as well.)

The spurious nil is then eliminated by vm-parse-addresses later on.

What confusion!

Revision history for this message
Ulrich Müller (ulm) wrote :

I'll fix this together with bug 544898.

Uday Reddy (reddyuday)
Changed in vm:
milestone: 8.2.0-devo → 8.1.91a
Revision history for this message
Ulrich Müller (ulm) wrote :

This should be fixed in r803 of the trunk. I haven't done extensive tests though.

Changed in vm:
status: Triaged → Fix Committed
Revision history for this message
Ulrich Müller (ulm) wrote :

For reference, adding some info from my e-mail message of 2010-03-24:

"[...] the first cond is strange, since add-to-list can never evaluate to nil: even if both the list-variable and the element are nil, then add-to-list will still return "(nil)" which is non-nil (i.e. it doesn't return the empty list, but a list with one element that is nil). So the first condition will always be true, and the remaining conditions cannot be reached."

I have eliminated these "add-to-list" conditions now.

Uday Reddy (reddyuday)
Changed in vm:
milestone: 8.1.92a → 8.1.91a
Uday Reddy (reddyuday)
Changed in vm:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.