Wishlist: allow patrons to add/edit their preferred name

[Jane Sandberg]

The preferred name feature is great! It would be even more helpful if patrons were able to add and edit these preferred names themselves, without requiring staff intervention. This would be beneficial for transgender patrons -- who may not want to out themselves to yet another person to get the correct name on to their account -- or for any patron that prefers self-service options to in-person transactions.

The Personal Information tab of the Account Preferences tab in the OPAC seems like a natural location for an interface to add/edit preferred names.

[Terran McCanna (tmccanna)]

+1

[Meg Stroup (mstroup)]

+1

I'd love to get my preferred name on my account :)

[Elizabeth Davis (elidavis)]

Would it be possible to have it on the self registration form as well?

[Scott Thomas (sthomas416)]

A patron requested that it be added to the self registration form.

[Scott Angel (scottangel1)]

I'll start working on this.

[Scott Angel (scottangel1)]

Here's my working branch
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/scottangel/LP1797025-allow-patrons-add-edit-preferred-name

[John Amundson (jamundson)]

I'm testing this on https://terran-master.gapines.org/ as part of Bug Squashing Week, and it doesn't seem to be working.

Chrome 110 - Incognito Tab
BR3 Patron - 99999396820/beatrices1234

If I enter my password and updated field(s), nothing seems to stick. The page simply refreshes, leaving the blank entries. Nothing useful is showing up in the console for me. Is this looking for a specific permission that patrons may not have or is something else going on?

[Terran McCanna (tmccanna)]

I'm seeing the same issue. I don't see anything missing from when I installed it, but when I refresh the server I'll try it again.

[Terran McCanna (tmccanna)]

I've installed this on my test server for a second time and I'm seeing some issues.

1 - On the Preferences page, the Preferred Name line displays the user's first and last name even when there isn't a preferred name entered. My personal preference would be to display the legal name first followed by the preferred name, but leave the preferred name blank if nothing is entered.

2 - The form that opens when clicking the Change button says "Update Username" at the top instead of Update Preferred Name.

3 - I'm not sure that we really need to list the current legal names on the form.

4 - I don't think the Current Password field is necessary. We don't require the patron to re-enter their current password when changing their other settings.

5 - As with the comments above, changes are not saving. The page just refreshes and clears out the fields.

[John Amundson (jamundson)]

Looking at this again on Terran's server.

1 - I think it makes sense to keep the preferred name higher than the legal name. Since the inclusion of preferred names, we've made more and more strides to have the preferred name the primarily displayed name in both the OPAC and staff client.

1a - if a Preferred name is already set, the field now displays twice - see screenshot.

2 - I see this, too.

3 - These fields are blank for me when testing with 99999396820/beatrices1234. This patron already has a preferred name set, so maybe that's contributing.

4 - Currently updating any setting requires entering the current password. Keeping this makes sense to me.

5 - This is still happening for me, too.

[Scott Angel (scottangel1)]

Ok, so there was a missing entry in the EGCatLoader.pm file. It's working now. I have it wrote to display the first given name, second given name and family name for the preferred name IF the preferred name isn't set. I figured that technically would be the preferred name instead of not displaying anything. If that's not the desired functionality then just let me know and I'll change it.

Here's my commit with the missing EGCatLoader.pm file.
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=34f66fcf940757cb0e23aafd2f584dba25788fb2

[Susan Morrison (smorrison425)]

The changes are now saving (and coming through on the staff client side), but there are some remaining issues from Terran and John's lists:

1a - if a Preferred name is set, the field displays twice

2 - The form that opens when clicking the Change button says "Update Username" at the top instead of Update Preferred Name.

3 - I'm not sure that we really need to list the current legal names on the form. (This updates to show the current preferred name, but I agree I don't think they need to see the current values in the form.)

Also, to remove the preferred name, you have to delete the values and then click Save. Maybe there can be a delete/remove option?

[Scott Angel (scottangel1)]

So I've got a few things updated here.
So I've fixed 1a, 2, & 3. I started to build out a 'clear' button for the preferred name but I needed more information on how this should be handled as any changes require password confirmation. So as it stands now if a patron decides to clear out their preferred name they'll click on the 'change' button. On the preferred name form they'll enter their password and click save. These fields are blank by default and will clear out any entries for the preferred name.

Here's the branch.
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/scottangel/LP1797025-allow-patrons-add-edit-preferred-name

[Shula Link (slink-g)]

It works, but there's no confirmation or alert telling the patron anything has happened after the form is submitted. Even redirecting to the main page so the patron could see their name had changed would be a good idea.

[Brett French (bsfrench)]

Agreed with Shula. It works with no issues (Dr. Anton Phibes is now the Abominable Dr. Anton Phibes) but it may be confusing to patrons that when the change is submitted correctly the form just goes blank. There is a message that will tell the patron if their password is incorrect, so maybe adding a "Changes saved!" message would be an easy solution. If not, redirecting the patron to the Personal Information page where they could see the change listed under "Preferred Name" would be beneficial.

[Christine Burns (christine-burns)]

I agree with the previous comments. Once the changes are saved the patron the page should redirect to the Personal Information page where they could see the change listed under "Preferred Name".

[Terran McCanna (tmccanna)]

This is very close, but moving back to "needswork" as per comments 14-16.

[Terran McCanna (tmccanna)]

I've signed off on Scott's work, squashed it and added a few things:

- Add redirect to prefs page upon submit
- Modify Current Preferred name to combine preferred name & legal name fields for consistency with how the names are used elsewhere in Evergreen)
- Add Current Preferred name to top of change form for consistency with other types of preference change forms
- Add a release note

Top two commits at:
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/LP1797025-allow-patrons-add-edit-preferred-name-2