The menu in top right corner of Web client should have a name

Bug #1796914 reported by Jane Sandberg
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
3.1
Fix Released
Low
Unassigned
3.2
Fix Released
Low
Unassigned

Bug Description

Currently, there is no text in this element that would give a screen reader user any indication of what the menu is. Additionally, it makes training difficult when there isn't a consistent way to refer to this menu.

Probably the best solution would be to make it consistent with other menus and actually make the name of the menu available for both sighted and blind users.

Another solution would be to add an aria-label to the <a> tag with the name of the menu.

The ang6 version of this menu does have a tooltip that refers to this menu as "Log out and more...". Perhaps this (or something similar) could be used as the name of this menu?

Revision history for this message
Jason Stephenson (jstephenson) wrote :

That type of menu is commonly referred to as a "Hamburger Menu."

 I think adopting "Logout and more..." as a tooltip/aria-label is a good idea.

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Shula Link (slink-g) wrote :

Fix pushed to: user/slink/lp1796974_top_right_menu_aria_label

I added both an aria-label and a title attribute to the menu, as my (admittedly cursory) research indicates that covers the most real-world situations.

Thanks,
Sam

tags: added: pullrequest
Revision history for this message
Shula Link (slink-g) wrote :

Oops! The W3C standard expressly prohibits using both. I chose to use the title attribute alone, both as it provides a tooltip, and to maintain consistency with the Angular7 version of the menu. A corrected commit has been pushed to the aforementioned branch.

Thanks,
Sam

Revision history for this message
Galen Charlton (gmc) wrote :

I pushed a signoff to

user/gmcharlt/lp1796914_signoff
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1796914_signoff

I took the liberty of squashing the two patches.

tags: added: signedoff
Changed in evergreen:
milestone: none → 3.3.2
importance: Undecided → Low
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Pushed to master, rel_3_3, rel_3_2, and rel_3_1. Thanks, Sam and Galen!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.