ImagePropertiesFilter docs refer to legacy properties

[Adam Spiers]

https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#imagepropertiesfilter refers to the 'architecture', 'hypervisor_type', 'hypervisor_version_requires', and 'vm_mode' properties; however the source code at https://github.com/openstack/nova/blob/05c379173569d2ea91741f3468d531d4edf7ef9d/nova/objects/image_meta.py#L474 shows that these are legacy properties which now have preferred alternatives:

    # The keys are the legacy property names and
    # the values are the current preferred names
    _legacy_property_map = {
        'architecture': 'hw_architecture',
        [... snipped ...]
        'vm_mode': 'hw_vm_mode',
        [... snipped ...]
        'hypervisor_version_requires': 'img_hv_requested_version',
        'hypervisor_type': 'img_hv_type',
    }

Therefore presumably the docs should be updated to refer to the new properties. If someone can confirm this is correct, I'm happy to push the doc fix for review.

[Matt Riedemann (mriedem)]

I can confirm those are the properties that the ImagePropertiesFilter are looking at and are aliased for the legacy names, however, the image properties documentation in glance still refers to the "legacy" property names, so if we're going to change the docs, they should be consistent:

https://docs.openstack.org/glance/latest/admin/useful-image-properties.html

Otherwise if I'm looking at the nova docs and don't see those properties in the glance image properties docs, I'd be confused.