add-model without --credential option updates remote credential content

Bug #1796618 reported by Anastasia
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Juju
Fix Released
High
Anastasia

Bug Description

Currently, when we add a hosted model via 'juju add-model' command, we implicitly update cloud credential content on the controller based on the client. This is unexpected and is a source of confusion to a user.

When 'add-model' is issued without a credential option, we should use the default credential for this user stored on the controller.

When 'add-model' is issued with a credential option:
* if there is a credential with the same name on the controller, update its content using credential from the client;
* if there is no credential with the same name on the controller, upload it from the client store.

Changed in juju:
milestone: none → 2.5-beta1
status: Triaged → In Progress
Revision history for this message
Anastasia (anastasia-macmood) wrote :

Quick fix PR against develop: https://github.com/juju/juju/pull/9312

Additional fix will be followed shortly. We need to separate AddCredential from UpdateCredential at the API layer.

Revision history for this message
Anastasia (anastasia-macmood) wrote :

The above PR has been Fix Committed.

I'll keep this bug for part 2 as described.

Revision history for this message
Anastasia (anastasia-macmood) wrote :

2nd part of the fix is to call the AddCredential method on Cloud facade rather than UpdateCredential.
PR against develop: https://github.com/juju/juju/pull/9342

Changed in juju:
status: In Progress → Fix Committed
Changed in juju:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.