Peer assessment deletion lang string needs to mention correct person deleting assessment

Bug #1796583 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon

Bug Description

Mahara 18.10RC1. Currently, the peer assessment deletion notification reads "Your peer assessment on page "Reflections" was deleted. You had written" But the "You" is actually the peer assessor. It should be changed to reflect that.

We are changing it to: Your peer assessor, [name], deleted their assessment on page "[title]". They had written:

Robert Lyon (robertl-9)
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Cecilia Vela Gurovic (ceciliavg) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9196
Committed: https://git.mahara.org/mahara/mahara/commit/c7a8a1b1cc0f5470ad189890d45040a7a1034222
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit c7a8a1b1cc0f5470ad189890d45040a7a1034222
Author: Robert Lyon <email address hidden>
Date: Mon Oct 8 07:27:17 2018 +1300

Bug 1796583: Making delete assessment email message better

behatnotneeded

Change-Id: I68e5b0680f80e416d9961e0d6c5fe66b652b584d
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9207

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9207
Committed: https://git.mahara.org/mahara/mahara/commit/b7f8631eda19d071b6a4e94564f3a04c63a5667b
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.10_STABLE

commit b7f8631eda19d071b6a4e94564f3a04c63a5667b
Author: Robert Lyon <email address hidden>
Date: Mon Oct 8 07:27:17 2018 +1300

Bug 1796583: Making delete assessment email message better

behatnotneeded

Change-Id: I68e5b0680f80e416d9961e0d6c5fe66b652b584d
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c7a8a1b1cc0f5470ad189890d45040a7a1034222)

Changed in mahara:
status: In Progress → Fix Committed
milestone: 18.10rc1 → 18.10.0
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.