Some animation frames suddenly invisible

[Benedikt Straub]

During a game, I suddenly got a strange graphics bug for a tailor´s shop and a drinking hall: These two buildings were suddenly invisible except for a single frame that was displayed normally at regular intervals. The bug disappeared spontaneously after a minute for the drinking hall, but remained for the tailors shop. The bug doesn´t appear again after saveloading.

The graphics report looks like it always does:

This is Widelands Version bzr8868[widelands] (Release)
[…]
Graphics: Try to set Videomode 800x600
Graphics: OpenGL: Version "3.0 Mesa 18.0.5"
Graphics: SDL_GL_RED_SIZE is 8
Graphics: SDL_GL_GREEN_SIZE is 8
Graphics: SDL_GL_BLUE_SIZE is 8
Graphics: SDL_GL_ALPHA_SIZE is 0
Graphics: SDL_GL_BUFFER_SIZE is 24
Graphics: SDL_GL_DOUBLEBUFFER is 1
Graphics: SDL_GL_DEPTH_SIZE is 24
Graphics: SDL_GL_STENCIL_SIZE is 8
Graphics: SDL_GL_ACCUM_RED_SIZE is 0
Graphics: SDL_GL_ACCUM_GREEN_SIZE is 0
Graphics: SDL_GL_ACCUM_BLUE_SIZE is 0
Graphics: SDL_GL_ACCUM_ALPHA_SIZE is 0
Graphics: SDL_GL_STEREO is 0
Graphics: SDL_GL_MULTISAMPLEBUFFERS is 0
Graphics: SDL_GL_MULTISAMPLESAMPLES is 0
Graphics: SDL_GL_ACCELERATED_VISUAL is 1
Graphics: SDL_GL_CONTEXT_MAJOR_VERSION is 2
Graphics: SDL_GL_CONTEXT_MINOR_VERSION is 1
Graphics: SDL_GL_CONTEXT_FLAGS is 0
Graphics: SDL_GL_CONTEXT_PROFILE_MASK is 2
Graphics: SDL_GL_SHARE_WITH_CURRENT_CONTEXT is 0
Graphics: SDL_GL_FRAMEBUFFER_SRGB_CAPABLE is 0
Graphics: OpenGL: Double buffering enabled
Graphics: OpenGL: Max texture size: 16384
Graphics: OpenGL: ShadingLanguage: "1.30"
**** GRAPHICS REPORT ****
 VIDEO DRIVER x11
 pixel fmt 370546692
 size 1280 1024
**** END GRAPHICS REPORT ****

No warnings or other unusual messages appeared.

[GunChleoc (gunchleoc)]

Do you still have a savegame for this?

[Benedikt Straub (nordfriese)]

This is fixed by saveloading, but I already got this three times with this savegame (the second time it crashed shortly afterwards with no error message at all), so there´s a chance it´ll surface again. No idea what triggers it, it seems to appear spontaneously after a long time of playing…

[GunChleoc (gunchleoc)]

I am suspecting https://bazaar.launchpad.net/~widelands-dev/widelands/trunk/revision/8847 at this point, because it's there that I last fiddled with the building drawing code.

[GunChleoc (gunchleoc)]

So, it would be interesting if this also happens with census & statistics switched off.

[Benedikt Straub (nordfriese)]

Just encountered this bug again with a smokery. I switched off census and stats and the building was shown normally again at once, and the bug didn´t reappear after turning them on again

[GunChleoc (gunchleoc)]

Thanks, this confirms that https://bazaar.launchpad.net/~widelands-dev/widelands/trunk/revision/8847 is the culprit.

[GunChleoc (gunchleoc)]

I don't understand the bug, so I'll remove the culprit for Build 20. The text z-layering bug is old, so we don't need to fix it with this release.

https://bugs.launchpad.net/widelands/+bug/1480927

[GunChleoc (gunchleoc)]

Fixed in build20-rc1