config download tarball getting added to git repo

[James Slagle]

The tarball of the config-download output that we put into the overcloud-config container is getting added to the git repo we create for the config-download contents.

We have code to add *.tar.gz to .gitignore, however when we use GitPython and run repo.index.add, this defaults to using force=True which the equivalent of git add -f, which adds even ignored files to the index.

The docs at
https://gitpython.readthedocs.io/en/stable/reference.html#git.index.base.IndexFile.add

actually say that the force keyword argument doesn't currently work.

So as a workaround we'll need to use the GitCmd interface to run a git command directly.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/607701

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/607701
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=356334b131a19b3273daf8a114682adad6693435
Submitter: Zuul
Branch: master

commit 356334b131a19b3273daf8a114682adad6693435
Author: James Slagle <email address hidden>
Date: Wed Oct 3 16:12:00 2018 -0400

    Don't add tarball to config-download dir

    GitPyton's repo.index.add defaults to force adding all ignored file
    patterns from .gitignore. This was causing the generated
    overcloud-config.tar.gz to also be included in the git repo. This caused
    the config-download directory to recursivley grow larger in size as each
    commit contained a tarball of the whole repo.

    Using repo.git.add instead allows the .gitignore to be honored so that
    the tarball isn't included in any commits.

    Change-Id: I5c7b4fc448d957e30c0ea386795c9b698e9febed
    Closes-Bug: #1795949

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/612163

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/612163
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=e8d9d162e5685af23e3aea924fc65f0da8026ca0
Submitter: Zuul
Branch: stable/rocky

commit e8d9d162e5685af23e3aea924fc65f0da8026ca0
Author: James Slagle <email address hidden>
Date: Wed Oct 3 16:12:00 2018 -0400

    Don't add tarball to config-download dir

    GitPyton's repo.index.add defaults to force adding all ignored file
    patterns from .gitignore. This was causing the generated
    overcloud-config.tar.gz to also be included in the git repo. This caused
    the config-download directory to recursivley grow larger in size as each
    commit contained a tarball of the whole repo.

    Using repo.git.add instead allows the .gitignore to be honored so that
    the tarball isn't included in any commits.

    Change-Id: I5c7b4fc448d957e30c0ea386795c9b698e9febed
    Closes-Bug: #1795949
    (cherry picked from commit 356334b131a19b3273daf8a114682adad6693435)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 10.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 9.5.0 release.