check_rabbitmq_queues.py reports "CRITICALS:" and "WARNINGS:" as plurals

Bug #1795944 reported by Drew Freiberger
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack RabbitMQ Server Charm
Fix Released
Low
James Page

Bug Description

Simple cleanup request.

the check_rabbitmq_queues.py script returns "CRITICALS" and "WARNINGS" instead of "CRITICAL" and "WARNING" as the nrpe standard responses. The text matching still works with the beginning of the string, but may be subject to future error if nrpe ever updates to use full word boundary matching.

James Page (james-page)
Changed in charm-rabbitmq-server:
status: New → In Progress
importance: Undecided → Low
milestone: none → 18.11
assignee: nobody → James Page (james-page)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-rabbitmq-server (master)

Fix proposed to branch: master
Review: https://review.openstack.org/611564

Revision history for this message
James Page (james-page) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-rabbitmq-server (master)

Reviewed: https://review.openstack.org/611564
Committed: https://git.openstack.org/cgit/openstack/charm-rabbitmq-server/commit/?id=43dc1d47a36270befe56bcc3ea3033be2b4fa293
Submitter: Zuul
Branch: master

commit 43dc1d47a36270befe56bcc3ea3033be2b4fa293
Author: James Page <email address hidden>
Date: Thu Oct 18 11:24:11 2018 +0100

    nrpe: drop use of plurals for alert levels

    Drop 'S' from CRITICALS AND WARNINGS to avoid any furture breakage.

    Change-Id: I3f4f2371135fcf5d49427259b8cb37fc71f78d25
    Closes-Bug: 1795944

Changed in charm-rabbitmq-server:
status: In Progress → Fix Committed
David Ames (thedac)
Changed in charm-rabbitmq-server:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.