InterfaceRoutes broke existing nic-configs

[Ben Nemec]

I was attempting to deploy an overcloud with the existing OVB nic-configs[1], and got the following:

openstack overcloud deploy --templates --libvirt-type qemu -e /usr/share/openstack-tripleo-heat-templates/environments/disable-telemetry.yaml -e /home/centos/openstack-virtual-baremetal/overcloud-templates/network-templates-v2/network-isolation-absolute.yaml -e /home/centos/openstack-virtual-baremetal/overcloud-templates/network-templates-v2/network-environment.yaml
/usr/lib/python2.7/site-packages/requests/__init__.py:91: RequestsDependencyWarning: urllib3 (1.21.1) or chardet (2.2.1) doesn't match a supported version!
  RequestsDependencyWarning)
Creating Swift container to store the plan
Creating plan from template files in: /tmp/tripleoclient-7N83af/tripleo-heat-templates
Plan created.
Processing templates in the directory /tmp/tripleoclient-7N83af/tripleo-heat-templates
WARNING: Following parameter(s) are defined but not used in plan. Could be possible that parameter is valid but currently not used.
  GnocchiRbdPoolName
  RootStackName
Deploying templates in the directory /tmp/tripleoclient-7N83af/tripleo-heat-templates
Initializing overcloud plan deployment
Creating overcloud Heat stack
The action raised an exception [action_ex_id=56ea3ecf-ef9b-4fac-b77a-e2b4b1b106ce, action_cls='<class 'mistral.actions.action_factory.DeployStackAction'>', attributes='{}', params='{u'skip_deploy_identifier': False, u'container': u'overcloud', u'timeout': 240}']
 ERROR: Property error: : resources.Controller<nested_stack>.resources.0<https://192.168.24.2:13808/v1/AUTH_bded2cc0b68348e2af891235bb957104/overcloud/puppet/controller-role.yaml>.resources.NetworkConfig.properties: : Unknown Property StorageMgmtInterfaceRoutes
Unexpected status FAILED for tripleo.deployment.v1.deploy_plan

It seems that [2] made the InterfaceRoutes parameters mandatory for some reason. Adding them to the OVB nic-configs seems to fix the problem, but this is a compatibility break that doesn't seem to have been intentional based on the fact that it was release noted as a feature, not an upgrade impact.

Note that the current OVB templates are already fixed by [3] so the problem shouldn't reproduce against master OVB anymore. However, I thought it should be reported.

1: https://github.com/cybertron/openstack-virtual-baremetal/tree/master/overcloud-templates/network-templates-v2
2: https://github.com/openstack/tripleo-heat-templates/commit/008f5f5d93977ac0a263bff8efc4d35c722ce282
3: https://github.com/cybertron/openstack-virtual-baremetal/commit/ca2f47d343c58344bd10dcb83b0100c3237133ac

[Ben Nemec (bnemec)]

Should be fixed by https://review.openstack.org/#/c/605807/