The configure_nagios() function runs on every hook
Bug #1795902 reported by
Barry Price
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical Livepatch Charm |
Fix Released
|
Medium
|
Barry Price |
Bug Description
It'd be nice to limit this to only run when it needs to (i.e. on upgrade/install hooks, or on changes to the nagios_* charm variables).
Related branches
~barryprice/charm-canonical-livepatch/+git/canonical-livepatch-charm:master
Merged
into
~livepatch-charmers/charm-canonical-livepatch:master
at
revision a71388035f67f69542bb1685da40f488b396c2e1
- Livepatch charm developers: Pending requested
-
Diff: 128 lines (+15/-31)4 files modifiedMakefile (+1/-1)
config.yaml (+0/-16)
layer.yaml (+1/-1)
reactive/canonical_livepatch.py (+13/-13)
Changed in canonical-livepatch-charm: | |
assignee: | nobody → Barry Price (barryprice) |
importance: | Undecided → Medium |
status: | New → In Progress |
Changed in canonical-livepatch-charm: | |
status: | In Progress → Fix Committed |
Changed in canonical-livepatch-charm: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
You can create a new flag to gate the setup_nrpe() call. Set that flag at the end of setup_nrpe(), and clear it in a @hook(' config- changed' )-decorated function. It should do the right thing (at least it does for me)