Jaeger driver is not compatible with Jaeger native span ids

Bug #1795664 reported by Shoham Peller
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
osprofiler
Fix Released
Undecided
Unassigned

Bug Description

Let's say service 1, which reports to Jaeger using jaeger's clients, calls service 2, which uses osprofiler with a Jaeger backend.
Service 1 will pass span ids and trace ids for service 2 to use. Those ids will be in Jaeger's format - 64 bit ints.
The jaeger driver currently assumes the IDs are UUIDs, and therefor fails to convert them to ints.

The jaeger driver needs to be compatible with the given IDs, which are produced by jaeger clients.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to osprofiler (master)

Reviewed: https://review.openstack.org/607200
Committed: https://git.openstack.org/cgit/openstack/osprofiler/commit/?id=1a18d0f9449ef88db69d1f26b303da08bfc3650b
Submitter: Zuul
Branch: master

commit 1a18d0f9449ef88db69d1f26b303da08bfc3650b
Author: Shoham Peller <email address hidden>
Date: Tue Oct 2 17:20:13 2018 +0300

    When shortening span-ids, check if they're already short

    If you're given an int, there's nothing to do, just return it

    Change-Id: I289dab8cfabaecf243fdc16b972695e83c83c3e4
    Closes-Bug: 1795664
    Signed-off-by: Shoham Peller <email address hidden>

Changed in osprofiler:
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/osprofiler 2.5.1

This issue was fixed in the openstack/osprofiler 2.5.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.