Jaeger driver is not compatible with Jaeger native span ids
Bug #1795664 reported by
Shoham Peller
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
osprofiler |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Let's say service 1, which reports to Jaeger using jaeger's clients, calls service 2, which uses osprofiler with a Jaeger backend.
Service 1 will pass span ids and trace ids for service 2 to use. Those ids will be in Jaeger's format - 64 bit ints.
The jaeger driver currently assumes the IDs are UUIDs, and therefor fails to convert them to ints.
The jaeger driver needs to be compatible with the given IDs, which are produced by jaeger clients.
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/607200 /git.openstack. org/cgit/ openstack/ osprofiler/ commit/ ?id=1a18d0f9449 ef88db69d1f26b3 03da08bfc3650b
Committed: https:/
Submitter: Zuul
Branch: master
commit 1a18d0f9449ef88 db69d1f26b303da 08bfc3650b
Author: Shoham Peller <email address hidden>
Date: Tue Oct 2 17:20:13 2018 +0300
When shortening span-ids, check if they're already short
If you're given an int, there's nothing to do, just return it
Change-Id: I289dab8cfabaec f243fdc16b97269 5e83c83c3e4
Closes-Bug: 1795664
Signed-off-by: Shoham Peller <email address hidden>