settings panel disappears instantly after opening it in Tango & Deere skin

[Matthew Nicholson]

Sometimes when opening the settings panel on the Tango skin in the Mixxx 2.2 beta the panel closes when the mouse is moved. I can work around this by clicking and dragging the settings button before releasing the mouse button.

[RJ Skerry-Ryan (rryan)]

Thanks for the report -- are you on Windows, macOS or Linux? What kind of mouse are you using (touchpad, standalone mouse, touchscreen)

[Matthew Nicholson (iamcodemaker)]

On macos, using the built in track pad.

[ronso0 (ronso0)]

Does this also happen with Deere?

In both Tango and Deere the skin settings toggle in the tool bar is in the exact same position as the close button in the skin settings menu is.

Could it be the menu opens so quickly that the trackpad release event is sent to the close button? Or that a false release event is sent as soon as the trackpad cursor is moved?

[Matthew Nicholson (iamcodemaker)]

Tested. This happens on the Deere skin too. And also, you may be right about the button up event, as whatever control my mouse ends up on gets activated.

[ronso0 (ronso0)]

btw, do the FX unit expand toggles work for you in Tango or LateNight?
They are also swapped underneath the pointer when clicked, but the actual widget switching might be slower than opening the sin menu..

[Matthew Nicholson (iamcodemaker)]

FX units expand fine under Tango

[ronso0 (ronso0)]

Does it also happen the other way around? (panel is open, click on Close button)

Are you keen on testing <EmitOnPressAndRelease>false</EmitOnPressAndRelease> for the skinsettings toggle?

In skin_settings.xml and topbar.xml replace
<Template src="skin:../Tango/button_2state.xml">
  <SetVariable name="TooltipId">skin_settings</SetVariable>
  <SetVariable name="ObjectName">SkinSettingsClose</SetVariable>
  <SetVariable name="Size">20f,24f</SetVariable>
  <SetVariable name="ConfigKey">[Master],skin_settings</SetVariable>
</Template>

with
<PushButton>
  <TooltipId>skin_settings</TooltipId>
  <ObjectName>SkinSettingsClose</ObjectName>
  <Size>20f,24f</Size>
  <EmitOnPressAndRelease>false</EmitOnPressAndRelease>
  <NumberStates>2</NumberStates>
  <State>
    <Number>0</Number>
  </State>
  <State>
    <Number>1</Number>
  </State>
  <Connection>
    <ConfigKey>[Master],skin_settings</ConfigKey>
    <ButtonState>LeftButton</ButtonState>
  </Connection>
</PushButton>

[Matthew Nicholson (iamcodemaker)]

It doesn't happen when closing the panel. I'll test with those changes this evening.

[Matthew Nicholson (iamcodemaker)]

Making those changes in the skin file fixes the issue.

I should also note, this issue does not occur when I build the latest git master from source. Not sure if that is relevant.

[ronso0 (ronso0)]

Fine, thanks!
Here's a quick fix for 2.2 then https://github.com/mixxxdj/mixxx/pull/1866

[Be (be.ing)]

Does this also affect the skin settings button in LateNight?

> I should also note, this issue does not occur when I build the latest git master from source. Not sure if that is relevant.

I don't think there have been any substantial changes to the skins or skin system in master that aren't in the 2.2 branch. However, our build server is building Mixxxx with the 10.13 macOS SDK. If you're using the 10.14 macOS SDK or running macOS 10.14 that could potentially explain this.

[ronso0 (ronso0)]

this bug popped up again in the 2.2 release.
https://github.com/mixxxdj/mixxx/pull/1954

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9461