docker-puppet privileged is not working as expected

Bug #1795558 reported by Michele Baldessari
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Michele Baldessari

Bug Description

We have the following code in docker-puppet.py:
service.get('prigileged', False),

This typo will prevent privileged true to work. This typo was added via If70da9804d8a26fff594f7282f64318fd6b79e2c

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/607106

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

Is it really high? It used to work that way as of Pike...

Changed in tripleo:
importance: High → Medium
Revision history for this message
Michele Baldessari (michele) wrote :

That code did not exist in pike. It is a recent thing
╭─michele@holtby /tmp/tripleo-heat-templates ‹master✔› 20:32:24
╰─$ git show 99f9e599d344 |grep prigileged
+ service.get('prigileged', False),
╭─michele@holtby /tmp/tripleo-heat-templates ‹master✔› 20:32:33
╰─$ git co 99f9e599d344~1
ess docker"
╭─michele@holtby /tmp/tripleo-heat-templates ‹4656dbe2e03e✔› 20:32:37
╰─$ grep -ir prigileged
╭─michele@holtby /tmp/tripleo-heat-templates ‹4656dbe2e03e✔› 20:32:43
╰─$
╭─michele@holtby /tmp/tripleo-heat-templates ‹4656dbe2e03e✔› 20:32:43
╰─$ git br -r --contains=99f9e599d344 origin/HEAD -> origin/master
  origin/master

It shows the patch was prolly never tested

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/607106
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=203a5f249ea449617fbc8526a8ed2d55d48aa349
Submitter: Zuul
Branch: master

commit 203a5f249ea449617fbc8526a8ed2d55d48aa349
Author: Michele Baldessari <email address hidden>
Date: Tue Oct 2 08:59:55 2018 +0200

    Fix privileged typo in docker-puppet.py

    We have the following code in docker-puppet.py:

       service.get('prigileged', False),

    This typo will prevent privileged true to work. This typo was added via
    If70da9804d8a26fff594f7282f64318fd6b79e2c

    Change-Id: Id85145656dbb82338c2a73915abdb64114bfc1fb
    Closes-Bug: #1795558

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 10.0.0

This issue was fixed in the openstack/tripleo-heat-templates 10.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.