Mahara

Correct tense in peer assessment language string

Bug #1795347 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Kristina Hoeppner
Mahara 18.10.0
18.10
Fix Released
Medium
Kristina Hoeppner
Mahara 18.10.0

Bug Description

Part of the string

$string['feedbacknotificationtext'] = "%s add a peer assessment on %s

It should read "added" though like in $string['feedbacknotificationhtml']

Thanks, dajan, for noticing that.

I'm not creating a new string because it's just a problem in English.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9164

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 18.10.0 → 18.10rc1
Kristina Hoeppner (kris-hoeppner)
no longer affects: mahara/19.04
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9164
Committed: https://git.mahara.org/mahara/mahara/commit/08794b2b37a87e786c53e84ee0b94db19bd7b8a1
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 08794b2b37a87e786c53e84ee0b94db19bd7b8a1
Author: Kristina D.C. Hoeppner <email address hidden>
Date: Mon Oct 1 22:37:55 2018 +1300

Bug 1795347: Correct tense in peer assessment notification

Also adding the peer assessment help file for the
Account -> Settings -> Notifications page

behatnotneeded

Change-Id: I287e64623bf4bc276219aa35236e2f6d4c91f927

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9195

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9195
Committed: https://git.mahara.org/mahara/mahara/commit/038a7656c64397d9ad789b080063366169721ac9
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit 038a7656c64397d9ad789b080063366169721ac9
Author: Kristina D.C. Hoeppner <email address hidden>
Date: Mon Oct 1 22:37:55 2018 +1300

Bug 1795347: Correct tense in peer assessment notification

Also adding the peer assessment help file for the
Account -> Settings -> Notifications page

behatnotneeded

Change-Id: I287e64623bf4bc276219aa35236e2f6d4c91f927
(cherry picked from commit 08794b2b37a87e786c53e84ee0b94db19bd7b8a1)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.