FTBFS with MySQL 8.0

[Lars Tangvald]

MySQL 8.0 removes the my_bool symbol, and it should simply be replaced with int or bool (this is also backwards-compatible with older versions of MySQL)

[Chris Hofstaedtler (zeha)]

As discovered upstream this is not entirely backwards compatible with older MySQL or current MariaDB. https://github.com/PowerDNS/pdns/pull/6842 fixed this upstream.

[Lars Tangvald (lars-tangvald)]

Actually, it should be backwards compatible.
In 5.x, my_bool is typedef'ed to char, but functions using it will still happily accept int or bool (and most of the code I see in Ubuntu assigns it as one of those).

Also, if it were not backwards-compatible, I don't think the upstream patch would work with MariaDB, since I believe «#if MYSQL_VERSION_ID >= 80000» would be true.

[Lars Tangvald (lars-tangvald)]

Hm, but I see it's referenced as causing a build failure with MariaDB without also checking the MariaDB flag, so maybe there are issues with the older versions (I tested briefly with 5.7)