Deleting pad in footprint editor causes segfault

[Brendan Haines]

Select (a single or multiple) pad and press delete key in footprint editor. Kicad immediately crashes.
This is a footprint that I created and was able to edit previously without issues.
I am able to delete graphic lines, but not pads.

---

After having this issue and restarting kicad a few more time, I can sometimes delete individual pads, and can occasionally delete multiple pads together.
I've also tried this with other footprints in other libraries and see the same intermittent problem.

---

dmesg:
[ 1336.343358] kicad[3455]: segfault at 55ff3aee22e0 ip 00007f821d2fac90 sp 000055b03b0efcc0 error 6 in libc-2.27.so[7f821d266000+1e7000]

Application: kicad
Version: 6.0.0-rc1-unknown-26838c6~66~ubuntu18.04.1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.58.0 OpenSSL/1.1.0g zlib/1.2.11 libidn2/2.0.4 libpsl/0.19.1 (+libidn2/2.0.4) nghttp2/1.30.0 librtmp/2.3
Platform: Linux 4.15.0-34-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.65.1
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.58.0
    Compiler: GCC 7.3.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

It's a little bit random as it's an accessing-freed-memory bug.

5.0 has the same logic, and so should be vulnerable even if it doesn't usually happen.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 13a41f11ebaf7e091386c8602f87c81a44aaceb4
https://git.launchpad.net/kicad/patch/?id=13a41f11ebaf7e091386c8602f87c81a44aaceb4