[dvr][ha] router state change cause unnecessary router_update

[LIU Yulong]

ENV:
devstack multinode master

Problem:
If dvr ha router have a state change event, the l3 agent will get unnecessary router_update message.

Example:
For dvr ha router, assuming it connected to public network and private network.
In dvr_snat namespace, this router will have sg-device and qg-device in the snat namespace.
When a HA state change happened. The sg-device related port and qg-device related port will update port binding host. Each one will send a router_update message to dvr_snat node. This will cause dvr ha router be process multipe times.

Reproduce:
kill the router 'master' keepalived instance in the dvr_snat node, manually produce a HA router state change.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/606385

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/606385
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=452b2824125641128b5297fcf84de090e0763740
Submitter: Zuul
Branch: master

commit 452b2824125641128b5297fcf84de090e0763740
Author: LIU Yulong <email address hidden>
Date: Sat Sep 29 18:04:10 2018 +0800

    Trigger router update only when gateway port IP changed

    During the ha router state change event, the gateway port only
    changed the L2 binding host. So l3 agent has the entire gateway
    port information. It is not necessary to send a router_update
    message to l3 agent again.

    Closes-Bug: #1795127
    Change-Id: Ia332421aff995f42e7a6e6e96b74be1338d54fe1

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 14.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/705421

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/705421
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4f7e1f6b9fa92a99d0a5df7e7440d62df3f51748
Submitter: Zuul
Branch: stable/rocky

commit 4f7e1f6b9fa92a99d0a5df7e7440d62df3f51748
Author: LIU Yulong <email address hidden>
Date: Sat Sep 29 18:04:10 2018 +0800

    Trigger router update only when gateway port IP changed

    During the ha router state change event, the gateway port only
    changed the L2 binding host. So l3 agent has the entire gateway
    port information. It is not necessary to send a router_update
    message to l3 agent again.

    Depends-On: https://review.opendev.org/708825/
    Closes-Bug: #1795127
    Change-Id: Ia332421aff995f42e7a6e6e96b74be1338d54fe1
    (cherry picked from commit 452b2824125641128b5297fcf84de090e0763740)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 13.0.7 release.