process-templates script doesn't write to output dir when base_path is set

[Bob Fournier]

When using the process-templates script with the -o OUTPUT_DIR param, the output is not written to this directory if the -p BASE_PATH is set to something other than the default ('.'). It will simply write the output to the base_path.

/home/stack/tripleo-heat-templates/tools/process-templates.py -p /home/stack/tripleo-heat-templates/ -r /home/stack/tripleo-heat-templates/roles_data.yaml -n /home/stack/tripleo-heat-templates/network_data.yaml -o /home/stack/dirname

Result:
/home/stack/dirname is created and empty
processed files are written to /home/stack/tripleo-heat-templates/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/605736

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/605804

[OpenStack Infra (hudson-openstack)]

Change abandoned by Harald Jensås (<email address hidden>) on branch: master
Review: https://review.openstack.org/605804

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/605736
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=47f47c1deaca950bb45babb5c0bb799897273413
Submitter: Zuul
Branch: master

commit 47f47c1deaca950bb45babb5c0bb799897273413
Author: Bob Fournier <email address hidden>
Date: Thu Sep 27 09:57:29 2018 -0400

    In process-templates script write output files to provided dir when using base path

    When running the process-templates script with both the -o OUTPUT_DIR and
    -p BASE_PATH options the output files were not being written to the output
    directory. This fix splits out the file path from the base path to properly
    write the files.

    Change-Id: I845e8a2cbd2b12a4a1552b2cfa3ac013466da6bd
    Closes-Bug: #1794769

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/607375

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/607375
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=c46632b8513ddba313632e253d771046676190dc
Submitter: Zuul
Branch: stable/rocky

commit c46632b8513ddba313632e253d771046676190dc
Author: Bob Fournier <email address hidden>
Date: Thu Sep 27 09:57:29 2018 -0400

    In process-templates script write output files to provided dir when using base path

    When running the process-templates script with both the -o OUTPUT_DIR and
    -p BASE_PATH options the output files were not being written to the output
    directory. This fix splits out the file path from the base path to properly
    write the files.

    Change-Id: I845e8a2cbd2b12a4a1552b2cfa3ac013466da6bd
    Closes-Bug: #1794769
    (cherry picked from commit 47f47c1deaca950bb45babb5c0bb799897273413)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.1.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/633808

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/633808
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=22f8389f067df502f499de4413bbd3ec69f14b20
Submitter: Zuul
Branch: stable/queens

commit 22f8389f067df502f499de4413bbd3ec69f14b20
Author: Bob Fournier <email address hidden>
Date: Thu Sep 27 09:57:29 2018 -0400

    In process-templates script write output files to provided dir when using base path

    When running the process-templates script with both the -o OUTPUT_DIR and
    -p BASE_PATH options the output files were not being written to the output
    directory. This fix splits out the file path from the base path to properly
    write the files.

    Change-Id: I845e8a2cbd2b12a4a1552b2cfa3ac013466da6bd
    Closes-Bug: #1794769
    (cherry picked from commit 47f47c1deaca950bb45babb5c0bb799897273413)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.3.0 release.