lxc-net.service is not properly ordered with network-online.target

[EOLE team]

I made several tests and I figure out that the lxc-net.service is missing a Wants= directive to be properly ordered against network-online.target.

As I understand the systemd.unit manpage, to be properly ordered a unit must define a Requires=/Wants= in addition to an After=/Before=.

Regards.

Distributor ID: Ubuntu
Description: Ubuntu 18.04.1 LTS
Release: 18.04
Codename: bionic

[Stéphane Graber (stgraber)]

Hmm, no, that would be wrong.

Wants=/Requires= would cause lxc-net to not start if network-online.target is missing or if it fails. We only want to start after it if it does exist, which is what After does.

[EOLE team (eole-team)]

Hello.

Only the Requires= will make it fail, no Wants=

    A weaker version of Requires=. Units listed in this option will be started if the
    configuring unit is. However, if the listed units fail to start or cannot be added to
    the transaction, this has no impact on the validity of the transaction as a whole.
    This is the recommended way to hook start-up of one unit to the start-up of another
    unit.

https://manpages.ubuntu.com/manpages/bionic/en/man5/systemd.unit.5.html

Regards.

[Launchpad Janitor (janitor)]

[Expired for lxc (Ubuntu) because there has been no activity for 60 days.]

[EOLE team (eole-team)]

There is still a problem :-/