When i'm using default roles data, my deployment fails on:
ERROR: 25814 -- Failed to pull image: 192.168.24.1:8787/tripleomaster/centos-binary-neutron-server:current-tripleo
The reason this happens is that the tripleo-container-image-prepare command has downloaded centos-binary-neutron-server-opendaylight image instead.
I investigated a bit, it seems tripleo-container-image-prepare has the logic to handle "OS::Heat::None" resource_registry values. However, we don't pass resource_registry to that command when calling it from the container-image-prepare.j2.yaml composable service:
https://github.com/openstack/tripleo-heat-templates/blob/300c366701ab09cbef9b58f82bfd615e0d901dea/puppet/services/container-image-prepare.j2.yaml#L89-L95
So the tripleo-container-image-prepare command is receiving the roles data with OpenDaylight service entries, but it's not receiving that the OpenDaylight services are mapped to None, so it thinks i'm using OpenDaylight.
FWIW it has always worried me that the neutron driver is implicitly derived from what services the role has deployed, instead of being indicated by an actual heat parameter. I'm not seeing any alternative to adding that parameter now, let me come up with something.