Incorrect numeric comparisons

[Lucian Petrut]

In a few places, we're using "is" or "is not", when comparing numeric variables.

This is incorrect and will give unexpected results when the types do not match (for example, if one of the variables is a long int): http://paste.openstack.org/raw/730618/

This issue only affects some metric related functions.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/604742
Committed: https://git.openstack.org/cgit/openstack/os-win/commit/?id=1f8200ef7909b13adf501f2805554160fa934f3a
Submitter: Zuul
Branch: master

commit 1f8200ef7909b13adf501f2805554160fa934f3a
Author: Lucian Petrut <email address hidden>
Date: Mon Sep 24 14:00:03 2018 +0300

    Fix incorrect numeric comparisons

    In a few places, we're using "is" or "is not", when comparing
    numeric variables.

    This is incorrect and will give unexpected results when the types
    do not match (for example, if one of the variables is a long int):
    http://paste.openstack.org/raw/730618/

    This change fixes those comparisons.

    Closes-Bug: #1794068

    Change-Id: Ibf28778879050cfdfa82ef4f9b587170dde6203f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/607547

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/607547
Committed: https://git.openstack.org/cgit/openstack/os-win/commit/?id=59e1117506067f42cec30e0eae6c7e92ffb0b6bc
Submitter: Zuul
Branch: stable/rocky

commit 59e1117506067f42cec30e0eae6c7e92ffb0b6bc
Author: Lucian Petrut <email address hidden>
Date: Mon Sep 24 14:00:03 2018 +0300

    Fix incorrect numeric comparisons

    In a few places, we're using "is" or "is not", when comparing
    numeric variables.

    This is incorrect and will give unexpected results when the types
    do not match (for example, if one of the variables is a long int):
    http://paste.openstack.org/raw/730618/

    This change fixes those comparisons.

    Closes-Bug: #1794068

    Change-Id: Ibf28778879050cfdfa82ef4f9b587170dde6203f
    (cherry picked from commit 1f8200ef7909b13adf501f2805554160fa934f3a)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/607867

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/607867
Committed: https://git.openstack.org/cgit/openstack/os-win/commit/?id=b4fa3ce9582c7c87174cf61bd501571da0eae968
Submitter: Zuul
Branch: stable/queens

commit b4fa3ce9582c7c87174cf61bd501571da0eae968
Author: Lucian Petrut <email address hidden>
Date: Mon Sep 24 14:00:03 2018 +0300

    Fix incorrect numeric comparisons

    In a few places, we're using "is" or "is not", when comparing
    numeric variables.

    This is incorrect and will give unexpected results when the types
    do not match (for example, if one of the variables is a long int):
    http://paste.openstack.org/raw/730618/

    This change fixes those comparisons.

    Closes-Bug: #1794068

    Change-Id: Ibf28778879050cfdfa82ef4f9b587170dde6203f
    (cherry picked from commit 1f8200ef7909b13adf501f2805554160fa934f3a)
    (cherry picked from commit 59e1117506067f42cec30e0eae6c7e92ffb0b6bc)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-win 4.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-win queens-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-win rocky-eol release.