OpenStack Identity (keystone)

Hacking check should check that log messages are not translated

Bug #1793421 reported by fupingxie
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
wangxiyuan
OpenStack Identity (keystone) stein-1

Bug Description

Related to https://bugs.launchpad.net/keystone/+bug/1777671 we should update our hacking check for log translations.

See original description
fupingxie (fpxie)
Changed in keystone:
assignee: nobody → fupingxie (fpxie)
fupingxie (fpxie)
Changed in ironic:
assignee: nobody → fupingxie (fpxie)
no longer affects: ironic
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/603953

Changed in keystone:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (master)

Change abandoned by fupingxie (<email address hidden>) on branch: master
Review: https://review.openstack.org/603953

fupingxie (fpxie)
Changed in keystone:
status: In Progress → Invalid
Colleen Murphy (krinkle)
summary: - Do not translate log messages
+ Hacking check should check that log messages are not translated
description: updated
Changed in keystone:
status: Invalid → Confirmed
importance: Undecided → Low
assignee: fupingxie (fpxie) → nobody
Revision history for this message
wangxiyuan (wangxiyuan) wrote :

https://review.openstack.org/#/c/604245/

Changed in keystone:
assignee: nobody → wangxiyuan (wangxiyuan)
OpenStack Infra (hudson-openstack)
Changed in keystone:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/604245
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=f39c28e44c1890cc9ac1a6af46d6e64c171f4c32
Submitter: Zuul
Branch: master

commit f39c28e44c1890cc9ac1a6af46d6e64c171f4c32
Author: wangxiyuan <email address hidden>
Date: Fri Sep 21 09:46:05 2018 +0800

    Update log translation hacking check

    Make sure the message in LOG must not be translated.

    Closes-bug: #1793421
    Change-Id: I86457db5dd0e9296d4130c3801c3257600571561

Changed in keystone:
status: In Progress → Fix Released
Lance Bragstad (lbragstad)
Changed in keystone:
milestone: none → stein-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/keystone 15.0.0.0rc1

This issue was fixed in the openstack/keystone 15.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.