ZFSSA failure on manage non-existent volume

[iain MacDonnell]

Attempting to manage a volume that doesn't exist fails with:

cinder-volume[20860]: ERROR oslo_messaging.rpc.server File "/opt/stack/cinder/cinder/volume/drivers/zfssa/zfssaiscsi.py", line 1212, in _get_existing_vol
cinder-volume[20860]: ERROR oslo_messaging.rpc.server err_msg = (_("Volume %s doesn't exist on the ZFSSA "
cinder-volume[20860]: ERROR oslo_messaging.rpc.server UnboundLocalError: local variable 'existing_vol' referenced before assignment

Two issues here -

1) It's trying to reference something that it just proved doesn't exist!

2) It's trying to raise the wrong exception type - should be ManageExistingInvalidReference, not InvalidInput

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/603925

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/603925
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=023c8f64e4ea38c71587ae20845a8016f5d572e2
Submitter: Zuul
Branch: master

commit 023c8f64e4ea38c71587ae20845a8016f5d572e2
Author: imacdonn <email address hidden>
Date: Wed Sep 19 23:01:39 2018 +0000

    ZFSSA handle manage nonexistent volume

    Fix handling of attempt to manage a volume (LUN) that doesn't exist
    on the ZFSSA backend.

    Change-Id: I9668667b98daeddc5beb12a0ba3e944d151fd42e
    Closes-Bug: #1793402

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 14.0.0.0rc1 release candidate.