Pcbnew doesn't allow saving when only changing text

[slowcoder]

When doing the following, Ctrl-S doesn't save, and the File > Save menu item is grayed out. Seems like it doesn't register as a change.

1. Open Pcbnew with a design
2. Edit a pre-existing text on either F.Silk or Cmts.User (could be more, but those are the ones I tested)
3. Save is not possible.

Version-information:

Application: kicad
Version: (6.0.0-rc1-dev-534-g7372acdaa), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.0.2p zlib/1.2.11
Platform: Linux 4.18.5 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.65.0
    Curl: 7.61.1
    Compiler: GCC 6.4.0 with C++ ABI 1010
Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=OFF
    KICAD_USE_OCC=OFF
    KICAD_SPICE=OFF

[Wayne Stambaugh (stambaughw)]

I am not able to duplicate this on windows. I wonder if it's specific to linux.

Application: kicad
Version: (6.0.0-rc1-dev-541-gebb74fcc2), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.0.2p (WinSSL) zlib/1.2.11 brotli/1.0.5 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.33.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 7.3.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[jean-pierre charras (jp-charras)]

I did not see this problem on Linux.

[Seth Hillbrand (sethh)]

I do not observe this issue on Linux with either silk or fab, in a footprint or independent.

Application: kicad
Version: (6.0.0-rc1-dev-542-gcd5b1c288), release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.52.1 OpenSSL/1.0.2l zlib/1.2.8 libidn2/0.16 libpsl/0.17.0 (+libidn2/0.16) libssh2/1.7.0 nghttp2/1.18.1 librtmp/2.3
Platform: Linux 4.9.0-8-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.62.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.52.1
    Compiler: GCC 6.3.0 with C++ ABI 1010

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

Reproduces on OSX with PCB text (ie: not in a module). I'll look into it....

[Jeff Young (jeyjey)]

@slowcoder, are you sure that was a version built from master? I can reproduce it on a 5.0.0 build, but not on one from master (labelled 6.0.0 but really 5.1.0).

[KiCad Janitor (kicad-janitor)]

Fixed in revision 5c600e992a99b094dc10b35bbe01812ba8d50b8f
https://git.launchpad.net/kicad/patch/?id=5c600e992a99b094dc10b35bbe01812ba8d50b8f

[Seth Hillbrand (sethh)]

@Jeff- Looks like slowcoder is running one right before I fixed that in master (adb89afe6) We should standardize which flags are meant to indicate that and comment it.

Generally, I don't like the idea of using a system-wide flag to indicate information in a general dialog (too much room for error). I'd prefer that we set a flag in the dialog from the calling function to indicate this. Thoughts?

[slowcoder (slowcoder)]

Confirmed fixed in ed94f2c5e023c4e95a49f8167d5f1b039303240d (i.e, post Seths adb89afe6 commit), but without 5c600e992a99b094dc10b35bbe01812ba8d50b8f (hasn't tricked down to github yet).

My apologies. I thought running a <48h old master would be close enough, but it seems you're faster than that. ;)

[Jeff Young (jeyjey)]

@Seth, yes, I hate this flags architecture. But I think we need to be even more aggressive and figure out how to get rid of it. (Well, not entirely. I think it's fine for something like a mark-and-sweep. Just not for communicating between tools or actions.)

[Jeff Young (jeyjey)]

BTW, I improved the safety of Seth's fix (by also checking for HIGHLIGHTED and BRIGHTENED), and merged it back to 5.0 as well.