undercloud ugprade root partition free space validation inaccurate

[James Slagle]

I'm trying to run openstack undercloud upgrade, it fails with:

An error occurred during configuration validation, please check your host configuration and try again. Error message: Task 'loop on existing volumes, check available space' failed:
Host: undercloud
Message: Minimum required for /: 20G - volume free space: 20.5

Isn't 20.5 greater than 20? :)

df shows:

[stack@instack ~]$ df
Filesystem 1K-blocks Used Available Use% Mounted on
/dev/vda1 78570904 52865476 21494792 72% /
devtmpfs 8188744 0 8188744 0% /dev
tmpfs 8215688 0 8215688 0% /dev/shm
tmpfs 8215688 1376 8214312 1% /run
tmpfs 8215688 0 8215688 0% /sys/fs/cgroup
tmpfs 1643140 0 1643140 0% /run/user/1000
tmpfs 512000 8 511992 1% /var/tmp/undercloud
tmpfs 512000 43868 468132 9% /var/log/heat-launcher

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/603523

[OpenStack Infra (hudson-openstack)]

Change abandoned by Juan Antonio Osorio Robles (<email address hidden>) on branch: master
Review: https://review.openstack.org/603523
Reason: abandoning temporarily to free up resources

[OpenStack Infra (hudson-openstack)]

Change abandoned by Juan Antonio Osorio Robles (<email address hidden>) on branch: master
Review: https://review.openstack.org/603523
Reason: Purging the gate to free up resources and address the timeout issues

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/603523
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=8a7fa0d712abb95374e37a78fe0ae19446d99b55
Submitter: Zuul
Branch: master

commit 8a7fa0d712abb95374e37a78fe0ae19446d99b55
Author: Alex Schultz <email address hidden>
Date: Tue Sep 18 17:37:12 2018 -0600

    Fix diskspace validation when size is the limit

    Previously if you had 25.5G free and the minimum should be 25, the task
    would fail. We do not want to fail when the amount of space free is
    equal to the minimum required space. We only want to fail when it's less
    than the required space. In this case the task needs to be updated to
    drop the equals from the failed_when so that if the amount free is equal
    to the minimum required amount then it will pass.

    Change-Id: I90b4a9617ba00610bee77af84bb1d12511ad452f
    Closes-Bug: #1793211

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/605815

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/605815
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=26d59879e3703f6c8058dbc2cc2fadf977627d03
Submitter: Zuul
Branch: stable/rocky

commit 26d59879e3703f6c8058dbc2cc2fadf977627d03
Author: Alex Schultz <email address hidden>
Date: Tue Sep 18 17:37:12 2018 -0600

    Fix diskspace validation when size is the limit

    Previously if you had 25.5G free and the minimum should be 25, the task
    would fail. We do not want to fail when the amount of space free is
    equal to the minimum required space. We only want to fail when it's less
    than the required space. In this case the task needs to be updated to
    drop the equals from the failed_when so that if the amount free is equal
    to the minimum required amount then it will pass.

    Change-Id: I90b4a9617ba00610bee77af84bb1d12511ad452f
    Closes-Bug: #1793211
    (cherry picked from commit 8a7fa0d712abb95374e37a78fe0ae19446d99b55)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-validations 10.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-validations 9.3.1 release.