FTBFS gcc8

[Andreas Hasenack]

https://launchpadlibrarian.net/387931929/buildlog_ubuntu-cosmic-amd64.squid3_3.5.27-1ubuntu1_BUILDING.txt.gz

error=deprecated -Wno-error=format-truncation -c -o IcmpPinger.o IcmpPinger.cc
IcmpPinger.cc: In member function ‘virtual void IcmpPinger::Recv()’:
IcmpPinger.cc:162:39: error: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct pingerEchoData’ with no trivial copy-assignment; use assignment or value-initialization instead [-Werror=class-memaccess]
     memset(&pecho, '\0', sizeof(pecho));
                                       ^
In file included from Icmp4.h:14,
                 from IcmpPinger.cc:18:
Icmp.h:25:8: note: ‘struct pingerEchoData’ declared here
 struct pingerEchoData {
        ^~~~~~~~~~~~~~

Upstream bug:
https://bugs.squid-cache.org/show_bug.cgi?id=4843

Upstream PR:
https://github.com/squid-cache/squid/pull/172

[Amos Jeffries (yadi)]

For the record:

All Squid-4+ versions have a hard GCC-5 minimal version requirement. Which should be fine for current Ubuntu.

All Squid-3 versions have a GCC-7 or lower build requirement. Optimally GCC-6 or lower, as implemented in the build dependencies for the Debian 3.5.23+ packages.

The Squid-4.x packages from Debian all integrate the upstream fix for this, as does the v4.1 package port in cosmic-proposed queue.

[Amos Jeffries (yadi)]

squid 4 packages are now in Cosmic